fix(tools): importers clear the read-only LFS bit before saving; 0.1.3 docs refresh #29

Merged
zwitschi merged 2 commits from packaging-setup-0.1.3 into main 2026-11-08 18:53:49 +01:00
Owner

Summary

The 0.1.3 packaging/setup patch, from what 0.1.x actually exposed.

Packaging fix

New Tools/ue_common.py:

  • make_writable() clears the read-only bit an LFS .umap checks out with. Without it save_map() returns False with no error and the staged actor is silently lost — which is exactly what happened when importing the hero.
  • require_saved() turns that silent failure into a logged one.

ue_hero_facade_import.py and ue_import_north_buildings.py now call it before saving (the map builders already did). Verified from a forced 0o444 map: map writable: chmod u+w … (was 0o444), then save_map: True, exit 0.

Docs

  • Docs/build.md: pipeline table lists the seven site FBXs plus frontage/north/hero/map steps and the shared FBX preset; packaging archive corrected to Builds/GigLineQA; packaged-log location and -qaselftest usage documented; new “Traps that cost real time in 0.1.x” table (read-only save, hero --out is the FBX, MPFB add-on path, shot actor quitting under QA, null-RHI trace trap).
  • Docs/setup.md: fresh-checkout build marked verified (2026-11-08) and its blocker closed; new optional-keys section for OPENROUTER_API_KEY and MAPBOX_ACCESS_TOKEN (gitignored .env; not needed by build, tests or release).
  • Docs/Architecture/07 + architecture.md: build-output path corrected and marked outside the repository.

Tests

5 new tests for ue_common — 54 total, all passing.

## Summary The `0.1.3` packaging/setup patch, from what `0.1.x` actually exposed. ### Packaging fix New `Tools/ue_common.py`: - `make_writable()` clears the read-only bit an LFS `.umap` checks out with. Without it `save_map()` returns **False with no error** and the staged actor is silently lost — which is exactly what happened when importing the hero. - `require_saved()` turns that silent failure into a logged one. `ue_hero_facade_import.py` and `ue_import_north_buildings.py` now call it before saving (the map builders already did). Verified from a forced `0o444` map: `map writable: chmod u+w … (was 0o444)`, then `save_map: True`, exit 0. ### Docs - `Docs/build.md`: pipeline table lists the seven site FBXs plus frontage/north/hero/map steps and the shared FBX preset; packaging archive corrected to `Builds/GigLineQA`; packaged-log location and `-qaselftest` usage documented; new **“Traps that cost real time in 0.1.x”** table (read-only save, hero `--out` is the FBX, MPFB add-on path, shot actor quitting under QA, null-RHI trace trap). - `Docs/setup.md`: fresh-checkout build marked verified (2026-11-08) and its blocker closed; new optional-keys section for `OPENROUTER_API_KEY` and `MAPBOX_ACCESS_TOKEN` (gitignored `.env`; not needed by build, tests or release). - `Docs/Architecture/07` + `architecture.md`: build-output path corrected and marked outside the repository. ### Tests 5 new tests for `ue_common` — **54 total**, all passing.
zwitschi added 1 commit 2026-11-08 18:50:42 +01:00
0.1.3 packaging and setup fixes from what 0.1.x actually exposed.

- New Tools/ue_common.py: make_writable() clears the read-only bit an LFS .umap
  checks out with (save_map() otherwise returns False silently and the staged actor
  is lost) and require_saved() makes that failure visible. ue_hero_facade_import and
  ue_import_north_buildings now call it; the map builders already did. Verified from
  a forced 0o444 map: chmod logged, save_map True, exit 0.
- Docs/build.md: pipeline table now lists the seven site FBXs plus frontage, north,
  hero and map steps and the shared FBX preset; packaging archive corrected to
  Builds/GigLineQA; packaged-log location and -qaselftest usage documented; new
  'Traps that cost real time in 0.1.x' table (read-only save, hero --out is the FBX,
  MPFB add-on path, shot actor quitting under QA, null-RHI trace trap).
- Docs/setup.md: fresh-checkout build marked verified 2026-11-08 and the blocker
  closed; new optional-keys section for OPENROUTER_API_KEY and MAPBOX_ACCESS_TOKEN
  (gitignored .env, not needed by build/tests/release).
- Docs/Architecture 07 + architecture.md: build-output path corrected, marked
  outside the repository.
- 5 new tests for ue_common (54 total).
zwitschi added 1 commit 2026-11-08 18:53:48 +01:00
zwitschi merged commit d6d3d54810 into main 2026-11-08 18:53:49 +01:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zwitschi/gig-line#29