security-game/DONE.md

DONE

Completed task sections moved from TODO.md. Sections are moved only when every item is finished and verified.

Project Setup

• Confirm Godot 4.x editor version to standardize on (Godot 4.3 stable, official build).
• Initialize a git repository and add a sensible root .gitignore for Godot and export artifacts.
• Scaffold the Godot project (project.godot, input map, folder structure).
• Add the GUT test framework and a runnable headless test command. (Deviation: GUT requires the editor plugin; replaced with a lightweight custom harness in src/test/test_runner.gd that runs without the editor.)
• Document setup, run, and test commands in README.md.

Prototype Scene

• Build a placeholder Hollywood Boulevard building entrance with steps, sidewalk, and a restricted door (procedural WorldBuilder).
• Add a controllable guard character with first-person camera controls (GuardController).
• Add basic keyboard/mouse input: move, look, interact, and cancel.
• Add a debug overlay showing NPC intent, escalation level, and shift timer (F toggles).

Core Simulation — Systems

• Implement ShiftCoordinator to start, advance, and end a shift.
• Implement VenueScenario as a Resource with locations, rules, NPC pools, and event pools.
• Implement an event scheduler that emits routine traffic and occasional scripted events (EventScheduler).
• Implement NPCController with movement toward waypoints, doors, and queues (movement handled by NpcAvatar).

NPC Interaction

• Define NpcProfile resources with intent, temperament, compliance, and escalation tolerances.
• Implement a lightweight finite state machine for NPC states (FSM).
• Implement the observation phase (Level 0) without forced intervention.
• Implement simple deterrence (Level 1): raise hand, point, eye contact, and head shake.
• Implement polite dialogue prompts and reaction logic driven by escalation level and profile.
• Implement formal warnings (Level 2) and make NPC reactions depend on profile and level.
  • Note (2026-10-31): the selectable dialogue tone-of-voice system (Professional/Friendly/Firm/ Suspicious) was intentionally removed from code and docs; reactions now depend solely on escalation level and NPC profile.
• Implement blocking and physical positioning (Level 3) without default force.
• Wire typical NPC reactions: leave, argue, ignore, record, move closer, or return later.

Access Verification

• Implement AccessVerifier with input from recognition, wristbands, IDs, tickets, credentials, and guest lists.
• Add wristband inspection UI showing color, pattern, date, and event marking.
• Model valid, expired, counterfeit, mismatched, missing, and ambiguous access artifacts.
• Record admit, redirect, hold, and refuse decisions for shift review.
• Add feedback scoring for incorrectly denying an authorized person or admitting an unauthorized one.

Escalation and Radio — Core

• Implement EscalationManager with explicit levels 0 through 5 and available-action gating.
• Implement the security-assistance radio call (Level 4) with a report form and arrival delay.
• Implement the emergency radio (Level 5) with hold-to-confirm and a report form.
• Add radio cooldown and battery limits to prevent spam.

Incident, Reputation, and Shift Review

• Implement IncidentRecorder emitting structured events (actor, behavior, action, evidence, escalation, outcome).
• Implement body-camera evidence tied to incident events.
• Implement ReputationEvaluator for peaceful resolutions, accuracy, complaints, damage, and entrance security.
• Implement CrowdSystem reactions to calm, aggressive, armed, and emergency situations.
• Implement the end-of-shift review screen summarizing decisions, consequences, and justification.

Scenario Content — Venue Data

• Author a minimal Hollywood Boulevard building scenario with tourist, confused-visitor, and simple-trespasser NPCs.
• Author a rare violent-threat event that requires justified emergency escalation.
• Add The Joke Shop scenario data: ID checks, guest lists, and wand-screening policy.
• Add the Hollywood Boulevard Late Night TV Studio scenario data with the full NPC mix and credential checks.
• Add a mental-health-crisis event with careful, respectful de-escalation guidance.

Tooling and Quality

• Add headless test coverage for access verification rules.
• Add headless test coverage for escalation transitions and scoring.
• Add fixed-seed scenario tests for deterministic NPC behavior.
• Set up GitHub Actions to run headless tests on push (ci.yml).
• Add a smoke-test checklist for launching one full shift (in README.md).

Bug Fixes — LATE shift phase

• Add a Rules.Phase.LATE entry (start_s 700) to shift_phases in all three venues.
• Confirm the LATE-tagged violent_emergency_event is now pulled from EventScheduler.pull_due.
• Add a test asserting the LATE phase is reached and the event is eligible in phase.

Missing PLAN Features — Protester NPC

• Add PROTESTER to Rules.NpcType and NPC_TYPE_NAMES.
• Add a protester profile (id "protester") with ARGUE/IGNORE/RECORD/CALL_SOMEONE reactions.
• Add a TYPE_COLORS entry for PROTESTER in npc_avatar.gd.
• Add routine protester events to the Hollywood Boulevard and TV Studio event pools.
• Add scenario tests asserting the protester profile and events exist.

Missing PLAN Features — “Call someone else” reaction

• Add CALL_SOMEONE to Rules.Reaction.
• Handle CALL_SOMEONE in NPCController._update_state_for_reaction (transitions to ARGUING).
• Give influencer, trespasser, and protester profiles CALL_SOMEONE weights.
• Add a reaction log line in GameManager and a Strings entry.
• Add a test that CALL_SOMEONE can be rolled and updates the FSM.

Missing PLAN Features — Door lock/secure

• Add a DoorState core class with locked/unlocked state and attempt_force().
• Add a visible door lock indicator (green open / red locked) to the world.
• Add the L key binding toggling the door lock, with HUD indication.
• Make FORCE_ENTRY reactions fail while the door is locked (thwarted outcome).
• Add Strings entries and a headless test for the lock state machine.

Missing PLAN Features — Flashlight

• Add a G key binding toggling the guard's flashlight.
• Attach a SpotLight3D to the guard that toggles with the flashlight.
• Widen NPC perception radius while lit at evening/late phases (perceive_guard bonus).
• Add Strings entries and a headless test for the perception effect.

Persistence

• Call Save.save_shift_result(review) from GameManager._on_shift_ended.
• Load past results and show record count + best score on the shift review screen.
• Add a test that a saved review round-trips through the Save helper.

Navigation

• Add a NavigationRegion3D with a hand-authored flat navmesh covering sidewalk, steps, and entrance.
• Switch NpcAvatar from direct movement to NavigationAgent3D path following (with direct-movement fallback).
• Keep per-intent waypoint and returning-trespasser re-targeting on the navmesh.
• Make the step geometry visual-only (no collider) so pathing to the entrance works.

Localization — JSON strings

• Move the string table to res://content/strings.en.json (41 keys).
• Load the JSON at startup; Strings.lookup/Strings.fmt signatures unchanged.
• Update the strings tests to confirm every JSON key resolves to a real value.

Distribution — Downloadable executables

• Commit export_presets.cfg with Linux, Windows, and macOS desktop presets.
• Add tools/build_releases.sh for headless release exports.
• Add docs/RELEASING.md with template installation, build, and Gitea release steps.
• Add a prominent Downloads section at the top of README.md linking to the release page.
• Add tools/publish_release.sh (Gitea API release + asset upload, requires GITEA_TOKEN).

CI/CD — Gitea Actions full build

• Add .gitea/workflows/build.yml with a fast checks job (import + headless tests on push/PR) and a full build job (export templates, Linux/Windows/macOS exports, artifact upload) on tags and workflow_dispatch.
• Tag builds automatically publish the Gitea release via tools/publish_release.sh using the GITEA_TOKEN secret.
• Remove the old .github/workflows/ci.yml to avoid double runs on hosts scanning both paths.
• Document the CI flow in docs/RELEASING.md.

Gameplay — Venue selection

• Add a V control that cycles Hollywood Blvd → The Joke Shop → TV Studio and restarts the shift (GameManager._cycle_venue), with a hud.venue_switched string entry.

🎨 Visual polish pass (v0.2.0, pre-release graphics)

• Phase-based lighting: per-phase sun direction/energy/color, sky gradient (ProceduralSkyMaterial), and ambient in GameManager.PHASE_LIGHTING; applied on phase change and shift start.
• Street lamps: poles with emissive bulbs + OmniLights on the sidewalk; WorldBuilder.set_night_mode switches bulbs/lights on at night.
• Marquee signage: emissive “STEP LINE” strips + Label3D above the entrance.
• Street dressing: crosswalk stripes, planters, and low-poly trees.
• NPC visual variety: per-seed height/brightness variation (deterministic LCG).
• Denser routine traffic (tourists/performers/influencers/trespassers).
• capture_screenshots.gd now fast-forwards to the LATE phase and captures a night set (lamps + marquee + flashlight cone); README gallery is now 2×3 (day + night); six shots regenerated in docs/screenshots/.
• config/version → 0.2.0; build/ artifacts rebuilt and Linux binary smoke-tested.
• New world/lighting headless tests (56 total).

Screenshot Refresh

• Regenerate and verify the six README screenshots from the current build.

🔴 PRIORITY — Ship downloadable builds (complete 2026-10-31)

• Install Godot 4.3 export templates locally.
• ./tools/build_releases.sh produces Linux/Windows/macOS artifacts (0.2.0).
• Linux binary smoke-tested (headless, 0 script errors).
• Publish the release: no local token needed — the host has the GITEA_TOKEN secret, so pushing the v0.2.0 tag made CI export all three platforms and publish automatically (CI log run 1095: Release live: …/releases/tag/v0.2.0, Job succeeded).
• Confirm links resolve: tag page and /releases return HTTP 200 publicly. Follow-up: anonymous asset downloads require sign-in on this host (host setting).
• CI packaging follow-up was already live (.gitea/workflows/build.yml on tags).

🎨 AI texture generation (OpenRouter)

• Extend tools/generate_textures.py with an OpenRouter image-API mode (--ai, --prompt, --name, --model, --size), decoding base64 PNG responses and clamping to ≤1024px.
• Verify a live --ai generation against a real OPENROUTER_API_KEY (generated ai/… set at 1024×1024; seedream minimum-pixel by requesting 2048 and downscaling.

🧹 Runtime hygiene + timeline/polish items

• RefCounted cycle cleanup: FSM now holds its owner via WeakRef; ShiftCoordinator is RefCounted (logic-only, no tree needs); persistence tests free the Save node. Test suite now exits with zero “resources still in use” warnings.
• Full-length shifts: the prototype now uses each scenario's shift_duration_s (900s ≈ 10-15 min per PLAN.md) instead of a hardcoded 300s test duration.
• Wand cooldown feel: a short WAND_COOLDOWN_S recharge between wand scans with a wand.recharge message (Open Polish item).

📦 Installer packaging (Windows NSIS + Linux AppImage)

• Export presets: binary_format/embed_pck=true on all platforms — every binary is now self-contained (all game data in one file; .pck no longer shipped).
• App icon: assets/textures/icon.png (1024) + multi-size icon.ico, copied to packaging/windows/step-line.ico and packaging/linux/step-line.png via the generator.
• NSIS script packaging/windows/step-line.nsi (installs Step Line.exe, uninstaller, shortcuts, registry entry; makensis /DVERSION=… /DARTIFACT=…).
• AppImage: packaging/linux/step-line.desktop, AppRun, appdata.xml, and build_appimage.sh (appimagetool, APPIMAGE_EXTRACT_AND_RUN=1).
• Local end-to-end: rebuilt embedded exports and produced step-line-0.2.0-x86_64.AppImage, ran it headless (0 script errors).
• CI: NSIS + AppImage steps added to .gitea/workflows/build.yml build job; publish glob already uploads build/step-line-*<ver>* (covers setup/AppImage names).
• CI run 1110 verified end-to-end (v0.2.1): NSIS installer step-line-setup-0.2.1.exe built, 7z l shows step-line.exe + uninstall.exe, AppImage built (33.9 MB), release v0.2.1 published, Job succeeded.
  • Gotchas fixed on the way: makensis needs -D defines (not /D) and absolute paths (it resolves relatives against the script dir); installed exe must be space-free (step-line.exe); icon.ico must use classic BMP entries (ImageMagick; PIL emits PNG-compressed ICOs NSIS rejects).

🎮 Assets & detailed graphics pass (textures, rigs, UI feedback)

• Authored texture set via tools/generate_textures.py (deterministic PIL): brick facade, seamless concrete, asphalt, awning, skyline, vignette, HUD icons, access-card art — all ≤1024px and power-of-two; imported under assets/textures/.
• Environment: textured facade + glass door, concrete sidewalk, asphalt street, striped awning with “STEP LINE”, generated skyline backdrop planes, soft sun shadows.
• NPCs: humanoid rig (torso/head/limbs) with archetype props (camera, delivery box, hat, sign, backpack), procedural walk bob, head-turns-toward-guard cue.
• UI/feedback: inspection artifact cards, mode icons (flashlight/door/wand), escalation vignette, body-camera overlay (corner brackets + REC + shift clock).
• Assets convention documented in README; test_asset_textures_present_and_pow2 guards the pipeline (57 tests total).
• (remaining, in TODO) crowd performance profiling and LOD/culling when the crowd grows.

CI — cache timeout mitigation

• Remove actions/cache@v4 from the checks job (runner cannot reach GitHub's cache service; ~2 min of retry timeouts per run; Godot import is fast without it).
• Add GODOT_SILENCE_ROOT_WARNING=1 to both jobs.
• Confirmed in run 1090: zero CacheService lines, 54/54 tests pass, job succeeds.
• Document the cache situation and re-enable path in docs/RELEASING.md.
• Ignore runner logs in .gitignore (.gitea/logs/).

Gameplay — Venue door-staff dialogue

• Add VenueScenario.door_staff_line(context, rng) picking a seeded-random line from door_staff_lines (empty for unknown contexts/venues).
• Wire GameManager to log venue lines: id/ticket check line when inspection opens, wand-check line when screening starts, prohibited-item line on correct wand refusal, and refusal line on denied entry (The Joke Shop flavor only).
• Add a headless test covering all Joke Shop contexts, unknown contexts, empty venues, and deterministic seeded picks.

Core Simulation — NPC Perception

• Implement a perception pass so NPCs react to the guard's gestures and proximity.
• Give NPCs local waypoints per intent (photo spots, queue, stage door, sidewalk exit) instead of all walking to the entrance.
• Add returning-trespasser behavior: an NPC that was directed away may circle back later in the shift.

Escalation and Radio — Responder Dispatch

• Spawn a dispatched security NPC / armed responder avatar that arrives at the venue after the call delay.
• Give the responder command, restraint, evacuation, and arrest outcomes that resolve the incident.
• Add a visible emergency-radio cooldown indicator in the HUD.

Scenario Content — Wand Screening (The Joke Shop)

• Implement the handheld wand inspection interaction with alerts from keys, belts, phones, and weapons.
• Enforce screening-before-entry flow and record false alarm / prohibited item decisions.
• Add venue-specific dialogue lines for door staff.

Polish and Accessibility

• Add aim-free targeting (Tab) and venue cycling (V). (The earlier dialogue tone picker was superseded and removed with the tone-of-voice system.)
• Add interaction alternatives that do not require precise aiming (e.g. scan-and-select pinned list of nearby NPCs).
• Add visual and audio feedback per escalation level (colors, tones, shake).
• Add audio for crowd ambience, radio responses, and confirmation prompts.
• Externalize dialogue and UI text for localization.

Generalized Game Asset Tooling

• Reuse the OpenRouter image backend for role-aware arbitrary asset generation.
• Add exact-dimension image crop and aspect-preserving resize commands.
• Audit existing assets for role-specific dimensions, aspect, alpha, and tile seams; report projection/perspective checks for visual review.
• Add automated tests and document asset-pipeline usage.

Generated Asset Integration

• Regenerate the AI asset set at role-specific aspect ratios and dimensions.
• Audit, process, and wire every generated asset into the game runtime.
• Add screenshot auditing and refresh the README screenshot gallery.

Access artifacts actually match the venue

Completed in the working tree (uncommitted with the control pass). Headless 74/74.

• Build artifacts from the event (override_access, carried items) and the venue policy, not from NpcType alone. (src/core/access_loadout.gd; spawn signal is (profile, intent, npc_id, event).)
• Joke Shop: valid ID+ticket, ID without ticket, expired/missing ID. Recognition does not auto-grant on every AUTHORIZED_GUEST.
• Wand venues roll carried_items per spawn (seeded); override can force a pocket.
• Studio counterfeit / follow-through events carry override_access.
• AccessVerifier.verify(..., already_screened) so a screened guest is not still denied.
• Joke Shop / Studio sidewalk and steps_end waypoints so film/photo intents do not walk to the entrance.
• Wand shortcut is C, not W. Tests: src/test/tests/test_access_loadout.gd.

Player control, focus ring, and radial action menu

Completed 2026-10-31 with ADR-0007–0010. Headless 77/77, plus a windowed smoke (src/test/smoke_focus_radial.gd) that opens the wheel and saves screenshots.

Locomotion

• Wand off W (now C + wheel). A/D allow/deny only while inspect/wand is open (they step the wheel while it is open). Q remains a closed-menu polite shortcut.
• Accel/decel on walk; gravity only when airborne; floor_snap_length 0.3.
• Mouse look only while captured and not input_locked. Freeze walk+look while radial / inspect / wand / radio / review is up. Recapture on close.
• cancel (Esc / RMB) closes the top modal first; with nothing open, Esc toggles mouse capture and RMB does nothing.

Focus and head ring

• Focus cone in src/game/npc_focus.gd (~10 m, ~10°). Closest-to-forward wins; occlusion ray skips building hits. Tab still cycles 12 m.
• 8-frame miss grace so walk-bob does not drop focus.
• Billboarded torus on Rig/Head; gold idle, brighter while the radial is open; Label3D display_name. HUD target line uses the display name, not the node name.
• Screen-center crosshair.

Radial HUD

• src/game/ui/action_radial.gd: LMB or Space opens when someone is focused. Opening click ignored for 120 ms. Slices: raise hand, point, head shake, polite, inspect, wand (grey if no wand), warning, block, radio assist. Emergency stays on R.
• Highlight by mouse angle, or A/D / arrows. Click slice or Space confirms. Esc / RMB closes with no action (no recorder event).
• Inspect / wand / radio slices close the wheel then open the existing panels. Freeze until that panel closes.
• Number keys 1–6 still work when the wheel is closed.

NPC display

• Procedural rig: neck, shoes, hair cap from seed, two eye spheres. Props, height variation, walk bob, notice-head-turn kept. Collision capsule scaled to rig height. Named Head is the ring attach point. Group npc.

Input, copy, tests

• Named input map: action_menu (Space/LMB), confirm (Space/Enter), cancel (Esc/RMB), inspect (E), wand (C). GameManager uses is_action_pressed.
• Windowed smoke: focus ring + name, wheel open/step/confirm/cancel (src/test/smoke_focus_radial.gd, exits non-zero on failure).
• README controls table, smoke checklist, test count, implemented/not-yet lists.

Runtime boot and spawn fixes

Found while running the windowed smoke; all verified with a boot run and regenerated screenshots.

• GameManager did not compile: radial was typed CanvasLayer, so radial.is_open / confirm_selected() made := inference fail. Typed as ActionRadial (the parse error would have broken the whole main scene).
• Camera sat at the guard's feet: Head had no height offset, and the new gravity pulled the guard to the floor. Head is now at y=1.6, and the guard spawns on the landing.
• Guard spawned inside the building collider and fell through the world. Building volume moved back to z ∈ [-8, -4] so the door / awning / marquee sit on its front face; the guard spawns in front of the door facing the street.
• Steps rose away from the door; treads now rise toward the entrance.
• Event scheduler was polled every physics frame (~60 Hz), spawning >1200 NPCs in seconds. ShiftCoordinator now accumulates time and pulls once per simulated second; regression test in test_scenarios.gd.
• Live NPCs capped at MAX_LIVE_NPCS (16); routine traffic is dropped at the cap and a scripted event evicts the oldest unfocused NPC.
• Removed the skyline backdrop planes (opaque black texture). Tracked as a follow-up in TODO.md.
• README screenshots regenerated with the fixed eye height and entrance staging.