Close the 0.9.3 UI polish milestone

Add deterministic captures 14-21 for the remaining screen-design states, fix the panel/button layout issues they exposed, and record 21/21 compare and judge results. Bump the source to 0.9.3 and move the completed milestone to DONE.md.

src/game/ui/radio_panel.gd

@@ -107,6 +107,7 @@ func _init() -> void:
 	var buttons := HBoxContainer.new()
 	vbox.add_child(buttons)
 	action_button = Button.new()
+	action_button.custom_minimum_size = Vector2(190, 0)
 	action_button.text = Strings.lookup("ui.radio_send_assist")
 	action_button.button_down.connect(func(): _start_hold())
 	action_button.button_up.connect(func(): _stop_hold(false))
@@ -114,6 +115,7 @@ func _init() -> void:
 	UiStyles.apply_button(action_button, 16)
 	buttons.add_child(action_button)
 	cancel_button = Button.new()
+	cancel_button.custom_minimum_size = Vector2(140, 0)
 	cancel_button.text = Strings.lookup("ui.radio_cancel")
 	cancel_button.pressed.connect(func(): cancelled.emit())
 	UiStyles.apply_button(cancel_button, 16)

src/game/ui/settings_panel.gd

@@ -76,14 +76,25 @@ func _build() -> void:
 	title.horizontal_alignment = HORIZONTAL_ALIGNMENT_CENTER
 	column.add_child(title)
 
+	var scroll := ScrollContainer.new()
+	scroll.name = "SettingsScroll"
+	scroll.custom_minimum_size = Vector2(640, 500)
+	scroll.size_flags_vertical = Control.SIZE_EXPAND_FILL
+	scroll.horizontal_scroll_mode = ScrollContainer.SCROLL_MODE_DISABLED
+	column.add_child(scroll)
+	var content := VBoxContainer.new()
+	content.size_flags_horizontal = Control.SIZE_EXPAND_FILL
+	content.add_theme_constant_override("separation", 12)
+	scroll.add_child(content)
+
 	var sens_row := VBoxContainer.new()
-	column.add_child(sens_row)
+	content.add_child(sens_row)
 	_sensitivity_value = _add_label_row(sens_row, "Mouse look sensitivity")
 	_sensitivity = _add_slider(sens_row, 0.0005, 0.0060, 0.0001)
 	_sensitivity.value_changed.connect(_on_sensitivity_changed)
 
 	var font_row := VBoxContainer.new()
-	column.add_child(font_row)
+	content.add_child(font_row)
 	_font_scale_value = _add_label_row(font_row, "HUD font scale")
 	_font_scale = _add_slider(font_row, 0.75, 1.75, 0.05)
 	_font_scale.value_changed.connect(_on_font_scale_changed)
@@ -91,15 +102,15 @@ func _build() -> void:
 	_invert_y = CheckButton.new()
 	_invert_y.text = Strings.lookup("ui.settings_invert")
 	_invert_y.toggled.connect(_on_invert_y_toggled)
-	column.add_child(_invert_y)
+	content.add_child(_invert_y)
 
 	_head_bob = CheckButton.new()
 	_head_bob.text = Strings.lookup("ui.settings_head_bob")
 	_head_bob.toggled.connect(_on_head_bob_toggled)
-	column.add_child(_head_bob)
+	content.add_child(_head_bob)
 
 	var diff_row := HBoxContainer.new()
-	column.add_child(diff_row)
+	content.add_child(diff_row)
 	var diff_label := Label.new()
 	diff_label.text = Strings.lookup("ui.settings_difficulty")
 	diff_label.size_flags_horizontal = Control.SIZE_EXPAND_FILL
@@ -111,13 +122,13 @@ func _build() -> void:
 	diff_row.add_child(_difficulty)
 
 	var audio_row := HBoxContainer.new()
-	column.add_child(audio_row)
+	content.add_child(audio_row)
 	audio_row.add_child(_volume_label("Master volume"))
-	_master = _add_slider(audio_row, 0.0, 1.0, 0.05)
+	_master = _add_slider(audio_row, 0.0, 1.0, 0.05, 120.0)
 	audio_row.add_child(_volume_label("SFX"))
-	_sfx = _add_slider(audio_row, 0.0, 1.0, 0.05)
+	_sfx = _add_slider(audio_row, 0.0, 1.0, 0.05, 120.0)
 	audio_row.add_child(_volume_label("Ambience"))
-	_ambience = _add_slider(audio_row, 0.0, 1.0, 0.05)
+	_ambience = _add_slider(audio_row, 0.0, 1.0, 0.05, 120.0)
 	_master.value_changed.connect(func(v): settings["master_volume"] = v)
 	_sfx.value_changed.connect(func(v): settings["sfx_volume"] = v)
 	_ambience.value_changed.connect(func(v): settings["ambience_volume"] = v)
@@ -125,15 +136,15 @@ func _build() -> void:
 	_reduce_motion = CheckButton.new()
 	_reduce_motion.text = Strings.lookup("ui.settings_reduce_motion")
 	_reduce_motion.toggled.connect(func(v): settings["reduce_motion"] = v)
-	column.add_child(_reduce_motion)
+	content.add_child(_reduce_motion)
 	_captions = CheckButton.new()
 	_captions.text = Strings.lookup("ui.settings_captions")
 	_captions.toggled.connect(func(v): settings["captions_enabled"] = v)
-	column.add_child(_captions)
+	content.add_child(_captions)
 
 	var replay_row := HBoxContainer.new()
 	replay_row.alignment = BoxContainer.ALIGNMENT_CENTER
-	column.add_child(replay_row)
+	content.add_child(replay_row)
 	var replay := Button.new()
 	replay.name = "ReplayTutorialButton"
 	replay.text = Strings.lookup("ui.settings_replay")
@@ -151,12 +162,12 @@ func _build() -> void:
 	controls_title.text = Strings.lookup("ui.settings_controls_help")
 	controls_title.add_theme_font_size_override("font_size", 13)
 	controls_title.modulate = Color(0.75, 0.8, 0.9)
-	column.add_child(controls_title)
+	content.add_child(controls_title)
 	var grid := GridContainer.new()
 	grid.columns = 4
 	grid.add_theme_constant_override("h_separation", 10)
 	grid.add_theme_constant_override("v_separation", 6)
-	column.add_child(grid)
+	content.add_child(grid)
 	for action in InputBindings.REMAPPABLE:
 		var label := Label.new()
 		label.text = str(action).replace("_", " ").capitalize()
@@ -207,12 +218,13 @@ func _volume_label(text: String) -> Label:
 	label.custom_minimum_size = Vector2(82, 0)
 	return label
 
-func _add_slider(parent: Control, min_v: float, max_v: float, step: float) -> HSlider:
+func _add_slider(parent: Control, min_v: float, max_v: float, step: float,
+		min_width: float = 420.0) -> HSlider:
 	var slider := HSlider.new()
 	slider.min_value = min_v
 	slider.max_value = max_v
 	slider.step = step
-	slider.custom_minimum_size = Vector2(420, 24)
+	slider.custom_minimum_size = Vector2(min_width, 24)
 	parent.add_child(slider)
 	return slider
 

src/game/ui/shift_review.gd

@@ -36,11 +36,14 @@ func _init() -> void:
 		dim.set_anchors_preset(Control.PRESET_FULL_RECT)
 		root.add_child(dim)
 
+	var center_host := CenterContainer.new()
+	center_host.set_anchors_preset(Control.PRESET_FULL_RECT)
+	root.add_child(center_host)
 	var center := VBoxContainer.new()
-	center.set_anchors_preset(Control.PRESET_CENTER)
+	center.custom_minimum_size = Vector2(760, 0)
 	center.alignment = BoxContainer.ALIGNMENT_CENTER
-	center.add_theme_constant_override("separation", 12)
-	root.add_child(center)
+	center.add_theme_constant_override("separation", 8)
+	center_host.add_child(center)
 
 	var title := Label.new()
 	title.text = Strings.lookup("review.title")
@@ -92,7 +95,7 @@ func _init() -> void:
 	center.add_child(_quit_button)
 
 func _style_review_button(button: Button) -> void:
-	button.custom_minimum_size = Vector2(300, 52)
+	button.custom_minimum_size = Vector2(300, 46)
 	UiStyles.apply_button(button, 22)
 
 func show_review(review: Dictionary, scenario: Resource, history: Array = [],

src/game/ui/ui_styles.gd

@@ -27,6 +27,11 @@ static func apply_button(button: Button, font_size: int = 0, compact: bool = fal
 	button.text_overrun_behavior = TextServer.OVERRUN_TRIM_ELLIPSIS
 	var margin_h := 12 if compact else 18
 	var margin_v := 7 if compact else 10
+	# clip_text removes the text-width contribution from the minimum size, so
+	# give unconstrained buttons a sane target width instead of collapsing them
+	# to the style margins (the radio action used to become a blank square).
+	if button.custom_minimum_size.x <= 0.0:
+		button.custom_minimum_size.x = 96.0 if compact else 160.0
 	var normal := _box(SURFACE, margin_h, margin_v)
 	var hover := _box(SURFACE_HOVER, margin_h, margin_v)
 	var pressed := _box(SURFACE_PRESSED, margin_h, margin_v)

src/test/capture_ui_states.gd

@@ -0,0 +1,202 @@
+extends SceneTree
+## Capture deterministic screenshots for the UI states that have design
+## references but no gallery shot yet: start menu, pause, settings, shift
+## review, emergency radio, radial menu, crowd panic and responder arrival.
+##
+## Usage:
+##   godot --path . --script res://src/test/capture_ui_states.gd -- \
+##     --out=res://docs/screenshots
+##
+## The script starts the real scene and stages the same state each run; it does
+## not depend on prior campaign progress. Capture filenames continue the gallery
+## at 14 and map to the catalogue entries in tools/screen_designs.py.
+
+const MAX_FRAMES := 6000
+
+var out_dir := "user://screenshots"
+var gm: Node = null
+var frames := 0
+var state := 0
+var state_frames := 0
+
+func _initialize() -> void:
+	for arg in OS.get_cmdline_user_args():
+		if arg.begins_with("--out="):
+			out_dir = arg.trim_prefix("--out=")
+	root.size = Vector2i(1280, 720)
+	root.add_child(load("res://scenes/main.tscn").instantiate())
+
+func _process(_delta: float) -> bool:
+	frames += 1
+	if gm == null:
+		gm = root.find_child("GameManager", true, false)
+		return false
+	if frames > MAX_FRAMES:
+		push_error("capture_ui_states timed out")
+		quit(1)
+		return true
+	state_frames += 1
+	match state:
+		0:
+			if state_frames == 20:
+				if gm.start_menu == null or not gm.start_menu.visible:
+					return false
+				# Deterministic free-play menu: no saved campaign status or Continue row.
+				gm.start_menu.open({})
+				gm.start_menu._continue_button.visible = false
+				gm.start_menu._status.text = ""
+				gm.start_menu._refresh_focus_targets()
+				gm.start_menu._focus_index(0)
+			if state_frames < 26:
+				return false
+			_shoot("14-start-menu.png")
+			gm.call("_on_venue_selected", "hollywood_building")
+			_next_state()
+		1:
+			if state_frames < 200:
+				return false
+			_stage_guard(0.0, 2.0)
+			gm.call("_open_pause")
+			_next_state()
+		2:
+			if state_frames < 30:
+				return false
+			_shoot("15-pause-overlay.png")
+			gm.call("_open_settings")
+			_next_state()
+		3:
+			if state_frames < 30:
+				return false
+			_shoot("16-settings-panel.png")
+			gm.settings_panel._on_cancel()
+			# The cancel returns to the game; stage an incident for the review.
+			if not gm.npcs.is_empty():
+				gm.call("_on_guard_target", gm.npcs[0])
+				gm.call("_apply_interaction", 2, "formal warning")
+			_next_state()
+		4:
+			if state_frames < 20:
+				return false
+			var review: Dictionary = gm.coordinator.build_review()
+			gm.shift_review_panel.show_review(review, gm.selected_scenario, [],
+				{"complete": false, "next_venue": "joke_shop", "shift_number": 2})
+			_next_state()
+		5:
+			if state_frames < 30:
+				return false
+			_shoot("17-shift-review.png")
+			gm.shift_review_panel.hide()
+			if gm.npcs.is_empty():
+				return false
+			gm.call("_on_guard_target", gm.npcs[0])
+			gm.call("_open_radio", true)
+			_next_state()
+		6:
+			if state_frames < 30:
+				return false
+			_shoot("18-emergency-radio.png")
+			gm.radio_panel.cancelled.emit()
+			if gm.npcs.is_empty():
+				return false
+			gm.call("_on_guard_target", gm.npcs[0])
+			gm.call("_open_radial")
+			_next_state()
+		7:
+			if state_frames < 30:
+				return false
+			_shoot("19-radial-menu.png")
+			gm.call("_cancel_radial")
+			# Stand at the street edge looking back at the entrance: the fleeing
+			# crowd runs toward the camera, with the door and steps behind them.
+			gm.guard.global_position = Vector3(0.0, 0.1, 14.0)
+			gm.guard.rotation.y = 0.0
+			gm.guard.head.rotation.x = deg_to_rad(2.0)
+			gm.hud.clear_log()
+			gm.hud.set_target_label("")
+			gm.hud.set_action_hint("")
+			# Place a compact crowd in front of the steps so the panic reads as a
+			# group reaction rather than a lone pedestrian.
+			var panic_spots := [
+				Vector3(-3.4, 0.1, 5.6), Vector3(-1.8, 0.1, 4.8),
+				Vector3(0.4, 0.1, 5.1), Vector3(2.0, 0.1, 4.6),
+				Vector3(3.4, 0.1, 5.4), Vector3(-2.6, 0.1, 7.0),
+			]
+			for i in mini(panic_spots.size(), gm.npcs.size()):
+				var staged: Node3D = gm.npcs[i]
+				staged.global_position = panic_spots[i]
+				staged.rotation.y = 0.0
+			gm.call("_on_crowd_changed", {"event": "crowd_panic", "panic": true})
+			_next_state()
+		8:
+			if state_frames >= 69:
+				gm.call("_clear_focus")
+				gm.hud.set_action_hint("")
+			if state_frames < 70:
+				return false
+			_shoot("20-crowd-panic.png")
+			gm.call("_on_responder_arrived", {
+				"type": "emergency",
+				"report": {"danger_level": 3, "weapons_seen": true},
+				"responder": "armed_responder",
+			})
+			# The arrest outcome keeps the responder moving toward the door
+			# instead of evacuating it; lock the door for the design state.
+			gm.door.set_locked(true)
+			if gm.world_builder:
+				gm.world_builder.set_door_locked(true)
+			gm.hud.set_door(true)
+			_next_state()
+		9:
+			if state_frames == 2:
+				# Park the responder on the approach and frame him from the
+				# entrance side; a deterministic staging, not a live chase.
+				for node in gm.npcs:
+					var c: Object = node.get_npc_controller() if node.has_method("get_npc_controller") else null
+					var is_responder: bool = node.name.begins_with("Responder") or (
+						c != null and c.profile != null and c.profile.id == "responder")
+					if is_responder:
+						node.visible = true
+						# Keep the dark responder against the lit steps rather than
+						# against the dark doorway, or the silhouette disappears.
+						node.global_position = Vector3(1.2, 0.1, 9.0)
+						node.rotation.y = 0.0
+						node.set_physics_process(false)
+					else:
+						# Remove the panic crowd from the responder frame.
+						node.visible = false
+						node.set_physics_process(false)
+				gm.guard.global_position = Vector3(0.0, 0.1, 14.0)
+				gm.guard.rotation.y = 0.0
+				gm.guard.head.rotation.x = deg_to_rad(2.0)
+				gm.hud.clear_log()
+				gm.call("_clear_focus")
+			if state_frames >= 29:
+				gm.call("_clear_focus")
+			if state_frames < 30:
+				return false
+			_shoot("21-responder-arrival.png")
+			quit(0)
+			return true
+	return false
+
+func _next_state() -> void:
+	state += 1
+	state_frames = 0
+
+func _stage_guard(yaw_deg: float, pitch_deg: float) -> void:
+	if gm == null or gm.guard == null:
+		return
+	gm.guard.global_position = Vector3(0.0, 0.1, 10.5)
+	gm.guard.rotation.y = deg_to_rad(yaw_deg)
+	gm.guard.head.rotation.x = deg_to_rad(pitch_deg)
+	gm.hud.clear_log()
+	gm.hud.set_target_label("")
+	gm.hud.set_action_hint("")
+
+func _shoot(file_name: String) -> void:
+	var dir := DirAccess.open(out_dir)
+	if dir == null:
+		DirAccess.make_dir_recursive_absolute(ProjectSettings.globalize_path(out_dir))
+	var img: Image = root.get_texture().get_image()
+	var err := img.save_png(out_dir.path_join(file_name))
+	print("%s -> err=%d (%dx%d)" % [file_name, err, img.get_width(), img.get_height()])

src/test/tests/test_ui_buttons.gd

@@ -25,7 +25,7 @@ func test_shared_button_states_are_complete() -> bool:
 		"the disabled state is visually distinct from normal")
 	button.text = "A very long localized action label that must not push the panel beyond the viewport"
 	var d := TestUtils.check(button.clip_text
-		and button.get_combined_minimum_size().x < 100.0,
+		and button.get_combined_minimum_size().x < 500.0,
 		"long action labels ellipsize instead of forcing a wide panel")
 	button.free()
 	return a and b and c and d