zwitschi
63aa0adf1c
New Geo/tools/mapbox_buildings.py (stdlib urllib) Tilequeries mapbox-streets-v8 / layer building at each building centroid and merges height/min_height/type with our OSM height + source (tag > levels > guess, reusing block_height_report.classify_height). Reports matches, close calls, disagreements (sorted worst first), our-only and mapbox-only cases, and writes optional JSON. First run over 72 buildings: 58 match, 5 close, 3 disagree, 6 non-building. - Mapbox independently classifies our roof/canopy/shelter volumes as roof, canopy or shelter -> corroborates the 0.1.2 finding. - The 3 disagreements are rear building=yes/apartments structures rendering at our 2-level guess (6.4 m) vs Mapbox's 3.0 m. - Every levels x 3.2 m building is ~0.6 m per 6 levels taller than Mapbox implies, i.e. Mapbox suggests 3.1 m per level. Recorded, not applied. classify_height() now also treats building=canopy as a non-building volume (found by this cross-check), with tests. Data handling: Mapbox terms restrict persisting/redistributing their data, so .gitignore covers Geo/raw/mapbox-cache/ and Geo/verification/*mapbox*; the tool refuses to cache a response containing the token, and the token is never written to the cache, report or JSON. Token comes from the ignored .env. Also: 17 new tests (29 total) for the compare/nearest/centroid/render helpers and the canopy rule; Geo/README inventory row; architecture 05 + architecture.md tools table updated per the new upkeep rule.
60 lines
2.3 KiB
Python
60 lines
2.3 KiB
Python
"""Tests for Geo/tools/block_height_report.py::classify_height.
|
|
|
|
The Geo tools live outside `Tools/`, so the test adds `Geo/tools` to `sys.path`
|
|
before importing the module by name.
|
|
"""
|
|
|
|
import os
|
|
import sys
|
|
import unittest
|
|
|
|
ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__), "..", ".."))
|
|
sys.path.insert(0, os.path.join(ROOT, "Geo", "tools"))
|
|
|
|
import block_height_report as bhr # noqa: E402
|
|
|
|
|
|
class ClassifyHeightTest(unittest.TestCase):
|
|
def test_height_tag_wins(self):
|
|
height, source = bhr.classify_height({"building": "yes", "height": "18.1"})
|
|
self.assertEqual(height, 18.1)
|
|
self.assertEqual(source, "height tag")
|
|
|
|
def test_height_tag_beats_levels(self):
|
|
height, _ = bhr.classify_height(
|
|
{"building": "yes", "height": "12.5", "building:levels": "4"})
|
|
self.assertEqual(height, 12.5)
|
|
|
|
def test_levels_derive_height(self):
|
|
height, source = bhr.classify_height(
|
|
{"building": "yes", "building:levels": "4"}, level_height=3.2)
|
|
self.assertEqual(height, 12.8)
|
|
self.assertIn("levels x", source)
|
|
|
|
def test_roof_is_not_a_building_volume(self):
|
|
# building=roof at layer=1 is an elevated canopy, not a two-storey block.
|
|
height, source = bhr.classify_height({"building": "roof", "layer": "1"})
|
|
self.assertEqual(height, 0.0)
|
|
self.assertIn("not a building volume (roof)", source)
|
|
|
|
def test_canopy_is_not_a_building_volume(self):
|
|
# building=canopy at layer=1, found by the Mapbox cross-check.
|
|
height, source = bhr.classify_height({"building": "canopy", "layer": "1"})
|
|
self.assertEqual(height, 0.0)
|
|
self.assertIn("not a building volume (canopy)", source)
|
|
|
|
def test_transit_shelter_is_not_a_building_volume(self):
|
|
height, source = bhr.classify_height(
|
|
{"building": "yes", "amenity": "shelter", "shelter_type": "public_transport"})
|
|
self.assertEqual(height, 0.0)
|
|
self.assertIn("not a building volume (shelter)", source)
|
|
|
|
def test_missing_data_falls_back_to_a_flagged_guess(self):
|
|
height, source = bhr.classify_height({"building": "yes"})
|
|
self.assertEqual(height, 2 * bhr.LEVEL_HEIGHT)
|
|
self.assertTrue(source.startswith("GUESS"))
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|