zwitschi/gig-line
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(review): rows 1, 2 and 3 approved - ReviewMap is signed off

Browse Source 
Owner approved the last three mannequin rows, so every ReviewMap capture is now approved except the
three hero-facade shots, which live in their own task.

Two housekeeping changes in the same table:

- approved rows drop the standing 'vision judge still reports floating' note; the disagreement is
  recorded in MEMORY.md, and the table is for approval state, not for a second copy of it.
- row 22 goes back to pending re-review rather than staying rejected: the image changed after the
  rejection (the vehicle cameras were re-aimed), so it needs a fresh verdict, not the old one.
This commit is contained in:
zwitschi committed 2026-11-09 21:31:06 +01:00
1 parent de83f990ac
commit a372fdf389
1 file changed
+11 -11
Download Patch File Download Diff File Expand all files Collapse all files
Screenshots/README.md
+11 -11
View File
@@ -13,9 +13,9 @@ Both capture passes are produced by [`Tools/render_screenshots.sh`](../Tools/ren
| # | Part | Item | Status | Note |
| --- | --- | --- | --- | --- |
| 1 | ReviewMap | ![character feet](review/review-character-feet.png) | [ ] | pending re-review: mannequin lowered 2 cm (8 -> 6 cm above the floor) |
| 2 | ReviewMap | ![character](review/review-character.png) | [ ] | pending re-review: mannequin lowered 2 cm (8 -> 6 cm above the floor) |
| 3 | ReviewMap | ![ground contact](review/review-ground-contact.png) | [ ] | pending re-review: mannequin lowered 2 cm (8 -> 6 cm above the floor) |
| 1 | ReviewMap | ![character feet](review/review-character-feet.png) | [x] | approved |
| 2 | ReviewMap | ![character](review/review-character.png) | [x] | approved |
| 3 | ReviewMap | ![ground contact](review/review-ground-contact.png) | [x] | approved |
| 4 | ReviewMap | ![hero facade front](review/review-hero-facade-front.png) | [ ] | moved to its own task: TODO.md -> hero facade rework |
| 5 | ReviewMap | ![hero facade oblique](review/review-hero-facade-oblique.png) | [ ] | moved to its own task: TODO.md -> hero facade rework |
| 6 | ReviewMap | ![hero portals](review/review-hero-portals.png) | [ ] | moved to its own task: TODO.md -> hero facade rework |
@@ -26,16 +26,16 @@ Both capture passes are produced by [`Tools/render_screenshots.sh`](../Tools/ren
| 11 | ReviewMap | ![shadow compare](review/review-shadow-compare.png) | [x] | approved |
| 12 | ReviewMap | ![vehicle](review/review-vehicle.png) | [x] | approved |
| 13 | DemoMap | ![crossing](demo/review-demo-crossing.png) | [x] | |
| 14 | DemoMap | ![feet](demo/review-demo-feet.png) | [x] | contact verified: feet and wheels touch the pavement with their shadows at the contact point; the vision judge still reports them as floating, which is advisory only |
| 14 | DemoMap | ![feet](demo/review-demo-feet.png) | [x] | approved |
| 15 | DemoMap | ![north buildings](demo/review-demo-north-buildings.png) | [x] | |
| 16 | DemoMap | ![retail frontage](demo/review-demo-retail-frontage.png) | [x] | |
| 17 | DemoMap | ![spawn view](demo/review-demo-spawn-view.png) | [x] | contact verified: feet and wheels touch the pavement with their shadows at the contact point; the vision judge still reports them as floating, which is advisory only |
| 18 | DemoMap | ![street level](demo/review-demo-street-level.png) | [x] | contact verified: feet and wheels touch the pavement with their shadows at the contact point; the vision judge still reports them as floating, which is advisory only |
| 19 | DemoMap | ![third person front](demo/review-demo-third-person-front.png) | [x] | contact verified: feet and wheels touch the pavement with their shadows at the contact point; the vision judge still reports them as floating, which is advisory only |
| 20 | DemoMap | ![third person walk](demo/review-demo-third-person-walk.png) | [x] | contact verified: feet and wheels touch the pavement with their shadows at the contact point; the vision judge still reports them as floating, which is advisory only |
| 21 | DemoMap | ![third person](demo/review-demo-third-person.png) | [x] | contact verified: feet and wheels touch the pavement with their shadows at the contact point; the vision judge still reports them as floating, which is advisory only |
| 22 | DemoMap | ![vehicle](demo/review-demo-vehicle.png) | [R] | fixed: cameras were aimed at the car's old position; the car is in frame now |
| 23 | DemoMap | ![wheel](demo/review-demo-wheel.png) | [x] | contact verified: feet and wheels touch the pavement with their shadows at the contact point; the vision judge still reports them as floating, which is advisory only |
| 17 | DemoMap | ![spawn view](demo/review-demo-spawn-view.png) | [x] | approved |
| 18 | DemoMap | ![street level](demo/review-demo-street-level.png) | [x] | approved |
| 19 | DemoMap | ![third person front](demo/review-demo-third-person-front.png) | [x] | approved |
| 20 | DemoMap | ![third person walk](demo/review-demo-third-person-walk.png) | [x] | approved |
| 21 | DemoMap | ![third person](demo/review-demo-third-person.png) | [x] | approved |
| 22 | DemoMap | ![vehicle](demo/review-demo-vehicle.png) | [ ] | pending re-review: cameras were aimed at the car's old position; the car is in frame now |
| 23 | DemoMap | ![wheel](demo/review-demo-wheel.png) | [x] | approved |
**Status:** [ ] pending · [x] approved · [R] rejected. "ReviewMap" rows are asset staging; "DemoMap" rows are the game map.