fix(hero): seat the façade detail on the wall, so it renders at all
The three hero captures showed a plain block with six columns because every applied detail sat BEHIND the wall's front face, inside the solid mass: Hero_Banner_1 y -1.08..-1.02 (55 cm inside) Hero_Portal_1 y -2.35..-1.15 (2 m inside) Hero_Window_1_1 y -0.60..-0.52 (2 cm inside) The colonnade, cornice and dentils happened to protrude, which is exactly what the shots showed. The depth is now stated once, in hero_facade_build.py: FRONT_Y is the wall's front face and seat_on_front() moves every applied part until its street-facing face sits at FRONT_Y + offset - 8 cm for banners and jambs, 5 cm for entablature and cornice, 3 cm for window panes, 4 cm for mullions, 10 cm for portal signs. It reports what it moved, 99 parts. After re-export, re-import and re-render the front elevation now shows the three red banners, the two window bands, the dentil course and the portals. What is still missing against the reference: rusticated banding on the stone, lettering on the motto band, grilles in the windows, a balustrade on the parapet, and the blank lintel band across the portals that the reference does not have. Rows 4, 5 and 6 are back to pending for review because the images changed.
This commit is contained in:
zwitschi committed
1 parent
01e49ff889
commit
7b9a7a3867
110 files changed
+183
-137
No files matched your search
@@ -16,9 +16,9 @@ Both capture passes are produced by [`Tools/render_screenshots.sh`](../Tools/ren
|
||||
| 1 | ReviewMap |  | [x] | approved |
|
||||
| 2 | ReviewMap |  | [x] | approved |
|
||||
| 3 | ReviewMap |  | [x] | approved |
|
||||
| 4 | ReviewMap |  | [ ] | moved to its own task: TODO.md -> hero facade rework |
|
||||
| 5 | ReviewMap |  | [ ] | moved to its own task: TODO.md -> hero facade rework |
|
||||
| 6 | ReviewMap |  | [ ] | moved to its own task: TODO.md -> hero facade rework |
|
||||
| 4 | ReviewMap |  | [ ] | re-rendered after the detail was seated on the wall: banners, windows, portals and dentils are visible now; still flat stone, no lettering, blank band over the portals |
|
||||
| 5 | ReviewMap |  | [ ] | re-rendered after the detail was seated on the wall: banners, windows, portals and dentils are visible now; still flat stone, no lettering, blank band over the portals |
|
||||
| 6 | ReviewMap |  | [ ] | re-rendered after the detail was seated on the wall: banners, windows, portals and dentils are visible now; still flat stone, no lettering, blank band over the portals |
|
||||
| 7 | ReviewMap |  | [x] | |
|
||||
| 8 | ReviewMap |  | [x] | approved |
|
||||
| 9 | ReviewMap |  | [x] | approved |
|
||||
|
||||
Reference in new issue
Block a user