docs(review): embed every demo shot inline, record the rule in AGENTS
Screenshots/README.md on this branch still used the path-only table, so a reviewer had to open six PNGs to judge a pass. Every shot now has its own section with the image embedded, its view, expected content and both verdicts, plus a status table at the top that links to them. The known-issues list becomes a table of issue -> version and item that owns it: pale hero stone, hero entrance doors, the bind-pose animation defect, unproven camera collision and the terrain-as-pavement strip all point at their TODO owner. Two stale entries removed: the theatre marquee exists (six trim actors staged) and 'materials not yet created' contradicted the scene conventions. AGENTS.md now says the README is updated with every visual change, that the image is embedded inline, and that approval ticks both the section and the table row. Also removed an orphan: review-demo-retail-frontage.png had been re-copied into this branch by the capture step although its geometry only exists on facade-retail-0.1.6.
This commit is contained in:
1 parent
05c1488c00
commit
304c1e9afd
3 files changed
+90
-29
No files matched your search
@@ -210,8 +210,8 @@ Any change that affects the game's appearance — meshes, materials, lighting, l
|
||||
|
||||
1. Run `Tools/render_screenshots.sh` (rebuilds `Game/GigLine/Content/Test/ReviewMap.umap` from current content, runs the game on it, captures the fixed camera list, copies the PNGs into `Screenshots/`).
|
||||
2. Optional pre-check with a vision model: `Tools/judge_screenshot.py --image <shot.png> --expect "<what it should show>"` (or `--shots` to run every shot in the README) flags likely-missing content before a human looks. It reads `OPENROUTER_API_KEY` from `.env` (ignored). Small helper only — it never replaces the human verdict.
|
||||
3. Update `Screenshots/README.md`: one row per screenshot with what it shows and an approval state; describe any new shots or scene changes in the same change.
|
||||
3. Update `Screenshots/README.md` **in the same change as any visual work** — every change that affects appearance, not only new shots: the image is **embedded inline** (``) with its view, expected content, verification and approval state, plus one row in the status table at the top. The review happens in the file; a path alone is not a review, and a shot whose README section is stale is a defect.
|
||||
4. The PNGs **are committed** so reviewers see exactly what the build rendered (`.gitignore` does not exclude them). Keep them in sync with this README: drop retired shots in the same change.
|
||||
5. Wait for the user's approval before treating a visual change as done; record approval by ticking the table in `Screenshots/README.md`.
|
||||
5. Wait for the user's approval before treating a visual change as done; record approval by ticking both the shot's section and its row in the status table in `Screenshots/README.md`.
|
||||
|
||||
New content that needs a different camera angle gets a new entry in the shot list in `Tools/ue_build_review_map.py`.
|
||||
Reference in new issue
Block a user