Retire the NPC review pages after owner acceptance and repoint every reference
Full build / Import + headless tests (push) Successful in 50s
Full build / Full desktop build + optional release (push) Skipped

This commit is contained in:
zwitschi committed 2026-11-06 18:37:17 +01:00
1 parent d5e180e50c
commit fcbeee0db2
25 files changed
+53 -221

No files matched your search

+16 -22
View File
@@ -820,13 +820,12 @@ blocked rig can no longer block the whole release.
`npc_casual`, front / three-quarter / profile. ADR-0018 removed the proportion warp, so
source proportions are accepted by definition (head 13.4 % of height, measured by
`npc_proportions`).
- [x] Owner review page with the visual signoff sheets and checklist:
[`docs/npc-visual-review.md`](docs/npc-visual-review.md) (the procedural-era review text
that used to live there is retired; its baseline sheets stay in `blender_previews/`).
- [x] Face-fidelity comparison sheet: [`docs/screens/npc-face-gate/`](../../docs/screens/npc-face-gate/README.md)
captures the Quaternius base, the procedural + MakeHuman head and a procedural crowd variant
at front / three-quarter / profile / 8 m. The page records the three options (full swap,
crowd only, add head detail) and recommends the full swap.
- [x] Owner visual signoff obtained (2026-11-06) on the roster, the faces, the head gear and the
hand/back gear. The review page and its sheets were retired after acceptance; the measurements
live on in `docs/3d-model-review.md` and `docs/blender-assets.md`.
- [x] Face-fidelity comparison was made and the full swap chosen; the comparison sheets were
retired with the review pages, and the decision is recorded in the follow-up section of
[`docs/adr/0018-quaternius-stage2-runtime-rig.md`](docs/adr/0018-quaternius-stage2-runtime-rig.md).
- [x] **Owner decision:** option (a) full swap (2026-11-05). Applied: all twelve characters are
baked from the three Quaternius sources inside 24,000 tris / 24,000 glTF vertices
(`a6ccd86`), and the gate was re-run.
@@ -834,7 +833,7 @@ blocked rig can no longer block the whole release.
`docs/npc-model-sourcing.md#shipped-roster-099-owner-chose-the-full-swap` and the
follow-up decision section of
[`docs/adr/0018-quaternius-stage2-runtime-rig.md`](docs/adr/0018-quaternius-stage2-runtime-rig.md).
- [ ] Owner visual signoff on the shipped roster: [`docs/npc-visual-review.md`](docs/npc-visual-review.md).
- [x] Owner visual signoff on the shipped roster (2026-11-06): accepted.
### Pilot rollout
@@ -873,9 +872,9 @@ regressing gear fit, budget or readability.
### Owner review findings (2026-11-06)
Review page: [`docs/npc-visual-review.md`](docs/npc-visual-review.md). The owner signed the roster
off **with follow-ups** and rejected checklist rows 3 (faces at portrait), 4 (hands and hand-held
gear) and 5 (head gear on the skull).
The owner signed the roster off **with follow-ups** and rejected three review rows (faces at
portrait, hands and hand-held gear, head gear on the skull). All follow-ups landed and the roster was
accepted on 2026-11-06; the review page and its sheets were then retired.
- [x] Worker torso holes on `npc_guard`: the build deleted `Worker_Vest`, which on the modular
Worker *is* the torso. Fixed by mapping it to `cloth` instead of deleting it.
@@ -903,9 +902,9 @@ gear) and 5 (head gear on the skull).
helmet dome covers the hair, and the cap reads as a cap rather than a visor.
- [ ] The eyes are single-colour quads on every base; a light sclera + pupil texture on the `Eye`
slot would finish the face at portrait distance.
- [x] Owner review page re-created for the second pass:
[`docs/npc-visual-review.md`](docs/npc-visual-review.md), with the hat/head-item table and a
refreshed eight-row checklist.
- [x] Review page re-created for the second pass, then retired after the owner accepted the roster
(2026-11-06). The durable evidence is `docs/3d-model-review.md`, the measurements in
`docs/blender-assets.md`, and the `capture_npc_gear.gd` / `capture_npc_baseline.gd` scripts.
- [-] Arm/torso intersection on `npc_dress`/`npc_jacket`/`npc_crowd_a`/`npc_crowd_d`: the baked
rest now aims the upper arm 7° out from vertical. Verified clear on the `casual` base; a
light clip remains on `worker`, so this needs either a wider angle or a per-base shoulder
@@ -970,15 +969,14 @@ contract.
regenerated) and re-ran the 24-NPC budget smoke (175,264 tris, 0.87 ms).
- [x] New [`src/test/capture_npc_gear.gd`](src/test/capture_npc_gear.gd) captures every gear piece
**worn by a real avatar** through the runtime attach path, one frame per item, and
`docs/blender_previews/sheet_npc_gear_on_character.jpg` collects them. It caught two things
the gear-on-character sheet (retired with the review pages) collected them. It caught two things
the asset renders could not: `sunglasses` were hidden inside the hair shell, and the outfit's
own gear double-attached over the tested piece (the capture now clears it first).
- [x] Owner feedback on grip height applied: every hand item drops into the palm
(`HAND_ITEM_DROP`, camera 0.085 m, flashlight 0.065, cup 0.050, umbrella 0.045, clipboard and
board 0.035, phone/radio/wand 0.030), the carried role props drop 0.06 m, and the lanyard
attach moved from y 1.30 to 1.38 for the taller Quaternius sternum.
- [x] `docs/npc-visual-review.md` row 4 now points at the gear-on-character sheet and the
measurement table. Only the owner verdict is outstanding.
- [x] Owner verdict on the hand-held gear: accepted (2026-11-06).
**Exit:** every gear piece and role prop has a measured fit against the Quaternius attach points,
the hand-held items are within +/-10 % of their authored real-world size, and the review page row 4
@@ -991,11 +989,7 @@ is signed off.
- [ ] Run `inspect`/`audit`/`fit`/`texels` and `npc_proportions.py report`; record the
12-variant measurement table.
- [-] Capture the 12 × 6 baseline and get owner approval before replacing the committed GLBs.
**Owner review page: [`docs/npc-visual-review.md`](docs/npc-visual-review.md)** — the
full-body roster, front/profile per role, the idle/sit/walk pose sheet and the 8 m crowd
strip, with an eight-row signoff checklist and the six issues found while capturing. The
GLBs are already committed (0.9.9); this signoff either accepts them or turns each rejected
row into a fix task.
Owner signed off on 2026-11-06; the review page was retired afterwards.
- [ ] Re-run the 24-NPC budget smoke and the Web/Compatibility capture; record frame time,
mesh/triangle counts and Web load before/after.
- [ ] Retire the procedural variants that are no longer used, keeping one tested fallback; update