From f84093adbaed0199c1d93b01a621d91b17104475 Mon Sep 17 00:00:00 2001 From: Zwitschi Date: Mon, 9 Nov 2026 11:50:07 +0100 Subject: [PATCH] feat(walk): a -walk harness flag, and the honest reason the stride shot is not in Screenshots 6 and 7 are approved, so the remaining 0.2.0 work is the traversal release check. This adds the piece of harness it needs - `-walk` holds forward input from the first frame, so the pawn actually crosses the sidewalk while the third-person rig follows it - and records what that check still lacks. A stride shot was attempted three times and removed: a fixed review camera cannot catch a pawn moving at 4.5 m/s. Each attempt framed it at a different distance and the last two missed it entirely, so shipping it would have been a broken shot with a green verification. The TODO item now says the blocker is the capture harness (a camera that tracks the pawn), not the game, and names where the shot goes back in. The flag stays because it is what the traversal check will drive. --- Game/GigLine/Content/Hollywood/DemoMap.umap | 4 ++-- .../Content/Hollywood/Site/M_Asphalt.uasset | 2 +- .../Content/Hollywood/Site/M_Concrete.uasset | 2 +- .../Content/Hollywood/Site/M_FacadeBanner.uasset | 2 +- .../Content/Hollywood/Site/M_FacadeGlass.uasset | 2 +- .../Content/Hollywood/Site/M_FacadeStone.uasset | 2 +- .../Hollywood/Site/M_FacadeStoneShadow.uasset | 2 +- .../GigLine/Content/Hollywood/Site/M_Ground.uasset | 2 +- .../Content/Hollywood/Site/M_KerbConcrete.uasset | 2 +- .../Content/Hollywood/Site/M_RoadPaint.uasset | 2 +- .../GigLine/Content/Hollywood/Site/M_Stucco.uasset | 2 +- .../Content/Hollywood/Site/Terrain_DEM.uasset | 2 +- .../Content/Hollywood/Textures/T_Asphalt_BC.uasset | 2 +- .../Content/Hollywood/Textures/T_Asphalt_R.uasset | 2 +- .../Hollywood/Textures/T_Concrete_BC.uasset | 2 +- .../Content/Hollywood/Textures/T_Concrete_R.uasset | 2 +- .../Hollywood/Textures/T_StoneAshlar_BC.uasset | 2 +- .../Hollywood/Textures/T_StoneAshlar_R.uasset | 2 +- .../Content/Hollywood/Textures/T_Stucco_BC.uasset | 2 +- .../Content/Hollywood/Textures/T_Stucco_R.uasset | 2 +- .../Hollywood/Theatre/SM_Trim_BladeSign.uasset | 2 +- .../Theatre/SM_Trim_BladeSignBracket.uasset | 2 +- .../Theatre/SM_Trim_BladeSignFrame.uasset | 2 +- .../Hollywood/Theatre/SM_Trim_MarqueeCanopy.uasset | 2 +- .../Hollywood/Theatre/SM_Trim_MarqueeFascia.uasset | 2 +- .../Hollywood/Theatre/SM_Trim_MarqueeSoffit.uasset | 2 +- Game/GigLine/Content/Test/ReviewMap.umap | 2 +- Game/GigLine/Source/GigLine/GigLineCharacter.cpp | 14 ++++++++++++++ Game/GigLine/Source/GigLine/GigLineCharacter.h | 6 ++++++ Screenshots/demo/review-demo-crossing.png | 4 ++-- Screenshots/demo/review-demo-north-buildings.png | 4 ++-- Screenshots/demo/review-demo-retail-frontage.png | 4 ++-- Screenshots/demo/review-demo-spawn-view.png | 4 ++-- Screenshots/demo/review-demo-street-level.png | 4 ++-- .../demo/review-demo-third-person-front.png | 4 ++-- Screenshots/demo/review-demo-third-person-walk.png | 3 +++ Screenshots/demo/review-demo-third-person.png | 4 ++-- TODO.md | 2 +- Tools/ue_build_review_map.py | 1 + 39 files changed, 67 insertions(+), 43 deletions(-) create mode 100644 Screenshots/demo/review-demo-third-person-walk.png diff --git a/Game/GigLine/Content/Hollywood/DemoMap.umap b/Game/GigLine/Content/Hollywood/DemoMap.umap index 5dac657..33347c8 100644 --- a/Game/GigLine/Content/Hollywood/DemoMap.umap +++ b/Game/GigLine/Content/Hollywood/DemoMap.umap @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:7dfbc6ee51a6d154ba912dfea32c443b482090eb8e5607ca7f5caae80de97d24 -size 782044 +oid sha256:68bfb2aff1d4f2afdcf9c514ef8322d08c263c90ab54115424bef3938340eac0 +size 782068 diff --git a/Game/GigLine/Content/Hollywood/Site/M_Asphalt.uasset b/Game/GigLine/Content/Hollywood/Site/M_Asphalt.uasset index 4b3ae4f..a5c6a38 100644 --- a/Game/GigLine/Content/Hollywood/Site/M_Asphalt.uasset +++ b/Game/GigLine/Content/Hollywood/Site/M_Asphalt.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:a1b7b441e59f1c790d2f63536bea6b1563205f737e9fd7cd03bffadfbac04bc8 +oid sha256:cfeb44958b1d5b6ae77b018b3cb3b7c2b2a357173cb2e2c3a1365f7fff710e36 size 10019 diff --git a/Game/GigLine/Content/Hollywood/Site/M_Concrete.uasset b/Game/GigLine/Content/Hollywood/Site/M_Concrete.uasset index ce1443f..7a33ddc 100644 --- a/Game/GigLine/Content/Hollywood/Site/M_Concrete.uasset +++ b/Game/GigLine/Content/Hollywood/Site/M_Concrete.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:7726905c110f74822ec68fd878de71fe47016c00f365c31b2a38dc49be0d3933 +oid sha256:5146d450b47d6d9a542f18afae4702b80db7b9c059d62ba0cb5e55130bc219f7 size 10024 diff --git a/Game/GigLine/Content/Hollywood/Site/M_FacadeBanner.uasset b/Game/GigLine/Content/Hollywood/Site/M_FacadeBanner.uasset index 7c625a4..496a63f 100644 --- a/Game/GigLine/Content/Hollywood/Site/M_FacadeBanner.uasset +++ b/Game/GigLine/Content/Hollywood/Site/M_FacadeBanner.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:ef60b037e6d3ff3fb336b299ea8b68c1632d7e1c2b859f2024b509043a7fe3ff +oid sha256:694ff53520e3e9afe6a74e2127f99629fe872a3c0f857c32bbfb0bb2b883b306 size 11419 diff --git a/Game/GigLine/Content/Hollywood/Site/M_FacadeGlass.uasset b/Game/GigLine/Content/Hollywood/Site/M_FacadeGlass.uasset index 35e2fcb..ab49d03 100644 --- a/Game/GigLine/Content/Hollywood/Site/M_FacadeGlass.uasset +++ b/Game/GigLine/Content/Hollywood/Site/M_FacadeGlass.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:bd0ab3f916af3c29d02215b882d8064061e043226e1d9978fbd5b2c3bd0af4ec +oid sha256:85a6842e333e9b83278a15aa7555f23eb77bfe157d39e11715450f82eb216131 size 11414 diff --git a/Game/GigLine/Content/Hollywood/Site/M_FacadeStone.uasset b/Game/GigLine/Content/Hollywood/Site/M_FacadeStone.uasset index 68f7530..63ba11a 100644 --- a/Game/GigLine/Content/Hollywood/Site/M_FacadeStone.uasset +++ b/Game/GigLine/Content/Hollywood/Site/M_FacadeStone.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:9bd3fdd5e329d29937a123c4dcbe6472170723b0a766a01b19cf224fc8bc8a82 +oid sha256:9a1420c863db7622cb16d409311e67284bcac872268fb08e3b11c7f364b70e02 size 17083 diff --git a/Game/GigLine/Content/Hollywood/Site/M_FacadeStoneShadow.uasset b/Game/GigLine/Content/Hollywood/Site/M_FacadeStoneShadow.uasset index 32bcc9e..13f605c 100644 --- a/Game/GigLine/Content/Hollywood/Site/M_FacadeStoneShadow.uasset +++ b/Game/GigLine/Content/Hollywood/Site/M_FacadeStoneShadow.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:a1065a5cb3aa5883e71124ad09aeb9b38f61559ca5313b74c2953c00fe61b7ed +oid sha256:7ec530da2fdeb6d0ed18b4c0a9eb3e32576d1ebe603b18e0d1bbc8528f6d8f24 size 17113 diff --git a/Game/GigLine/Content/Hollywood/Site/M_Ground.uasset b/Game/GigLine/Content/Hollywood/Site/M_Ground.uasset index 73f6fd7..5e6934b 100644 --- a/Game/GigLine/Content/Hollywood/Site/M_Ground.uasset +++ b/Game/GigLine/Content/Hollywood/Site/M_Ground.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:d7082d4e53451fc44d97c70e8361f18132644d02fe23426225e439cfa56752b7 +oid sha256:10a8c1bf7b92c42ef7fab90ba9cb6cef0d97fb1e16eee1d389d9ddc5318729b9 size 10014 diff --git a/Game/GigLine/Content/Hollywood/Site/M_KerbConcrete.uasset b/Game/GigLine/Content/Hollywood/Site/M_KerbConcrete.uasset index 9803c2e..c6bcb41 100644 --- a/Game/GigLine/Content/Hollywood/Site/M_KerbConcrete.uasset +++ b/Game/GigLine/Content/Hollywood/Site/M_KerbConcrete.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:d6922192c3601bb65a418caa5aa8be8d806b494796f373853cb271cac5dfc68a +oid sha256:5df3b66f676700118ba3992ff4b2932c38cff23de6cdc30cf71106b3c0ee1326 size 10044 diff --git a/Game/GigLine/Content/Hollywood/Site/M_RoadPaint.uasset b/Game/GigLine/Content/Hollywood/Site/M_RoadPaint.uasset index b1264da..5a87677 100644 --- a/Game/GigLine/Content/Hollywood/Site/M_RoadPaint.uasset +++ b/Game/GigLine/Content/Hollywood/Site/M_RoadPaint.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:25e0373c5d4e65da8f3b867b3cc37060a96f0038cf32aae89e64c449c3c6040c +oid sha256:b31e8281dec663399f09805ebb6e5130ff3e09b009ad5e47ff9bcdd43369d917 size 10029 diff --git a/Game/GigLine/Content/Hollywood/Site/M_Stucco.uasset b/Game/GigLine/Content/Hollywood/Site/M_Stucco.uasset index 9598348..d6b54e7 100644 --- a/Game/GigLine/Content/Hollywood/Site/M_Stucco.uasset +++ b/Game/GigLine/Content/Hollywood/Site/M_Stucco.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:41e37f191f2241d48b91cf3e3d45d24979f09c09d141ef94a7b3213c629043e1 +oid sha256:d68e1cfc648c22b015fde3e7b1281073cd8e87a3f4af3d6f6937b88d43945e9d size 11389 diff --git a/Game/GigLine/Content/Hollywood/Site/Terrain_DEM.uasset b/Game/GigLine/Content/Hollywood/Site/Terrain_DEM.uasset index 67bb042..168a082 100644 --- a/Game/GigLine/Content/Hollywood/Site/Terrain_DEM.uasset +++ b/Game/GigLine/Content/Hollywood/Site/Terrain_DEM.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:473f7e8aef279569e1958f910498e664009b9f1d56d0e6bd1fc1a6cc81c940a7 +oid sha256:dc005ac965f18eb54a3958874f6d12a3916891ac6ddc0634e68f7a0da0420a5c size 357901 diff --git a/Game/GigLine/Content/Hollywood/Textures/T_Asphalt_BC.uasset b/Game/GigLine/Content/Hollywood/Textures/T_Asphalt_BC.uasset index c75e1b4..fbc0582 100644 --- a/Game/GigLine/Content/Hollywood/Textures/T_Asphalt_BC.uasset +++ b/Game/GigLine/Content/Hollywood/Textures/T_Asphalt_BC.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:a2123883fe21887d32ace1f8dfd0b727a198cc581aec6fefdf103c945f8616c0 +oid sha256:3332044a02f1d4ceb3d98a8d7f5ec5308695c4d45e024aa3a035ccb3643e2564 size 70879 diff --git a/Game/GigLine/Content/Hollywood/Textures/T_Asphalt_R.uasset b/Game/GigLine/Content/Hollywood/Textures/T_Asphalt_R.uasset index 32b339b..df63854 100644 --- a/Game/GigLine/Content/Hollywood/Textures/T_Asphalt_R.uasset +++ b/Game/GigLine/Content/Hollywood/Textures/T_Asphalt_R.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:ed527aa31c0351c70e289cf4655b60f1182084260ac6e385143ede7fcf27690a +oid sha256:3e82d8f5d0d0fe2ef030fbe9b9943aef2f9cd19bbd1743f845c81208274cf10f size 29011 diff --git a/Game/GigLine/Content/Hollywood/Textures/T_Concrete_BC.uasset b/Game/GigLine/Content/Hollywood/Textures/T_Concrete_BC.uasset index 6ce5a4a..1462115 100644 --- a/Game/GigLine/Content/Hollywood/Textures/T_Concrete_BC.uasset +++ b/Game/GigLine/Content/Hollywood/Textures/T_Concrete_BC.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:4809ce7c64b34d95eccd20056736d234c62b282a0b1612f2a758962470d3e81f +oid sha256:036e739ca0850310a816a2d94d6fae6b003083f41a25f592c6f0ff3ec0b01376 size 58568 diff --git a/Game/GigLine/Content/Hollywood/Textures/T_Concrete_R.uasset b/Game/GigLine/Content/Hollywood/Textures/T_Concrete_R.uasset index 8305d3d..c175d5e 100644 --- a/Game/GigLine/Content/Hollywood/Textures/T_Concrete_R.uasset +++ b/Game/GigLine/Content/Hollywood/Textures/T_Concrete_R.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:352d6061a481d853574a1a1411df4b3c4a93e4ac1c04328c7f6ec64f32b561a6 +oid sha256:c211098984147983ffcaa547c9de95eac47fd40a02629d6dbe46e30db5e54445 size 17517 diff --git a/Game/GigLine/Content/Hollywood/Textures/T_StoneAshlar_BC.uasset b/Game/GigLine/Content/Hollywood/Textures/T_StoneAshlar_BC.uasset index 3fba834..7ad9e80 100644 --- a/Game/GigLine/Content/Hollywood/Textures/T_StoneAshlar_BC.uasset +++ b/Game/GigLine/Content/Hollywood/Textures/T_StoneAshlar_BC.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:e04608c7bc2a1ee87d880a7cb470bbea3c4f90f413648af5953f38c2f238f2bb +oid sha256:19f5d1c65805354300d729e8af1013f207a9ee880738575f5eb1fe8fecc3e135 size 40610 diff --git a/Game/GigLine/Content/Hollywood/Textures/T_StoneAshlar_R.uasset b/Game/GigLine/Content/Hollywood/Textures/T_StoneAshlar_R.uasset index 130b3f3..04e979f 100644 --- a/Game/GigLine/Content/Hollywood/Textures/T_StoneAshlar_R.uasset +++ b/Game/GigLine/Content/Hollywood/Textures/T_StoneAshlar_R.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:31392f9d13c9603bb39598f714a145f8f17878a346c4c73caef202c0a596e8dc +oid sha256:e736c20a959e1336976b2847b9882ca392ff214959f4c18745a50037d9e3f3cc size 18770 diff --git a/Game/GigLine/Content/Hollywood/Textures/T_Stucco_BC.uasset b/Game/GigLine/Content/Hollywood/Textures/T_Stucco_BC.uasset index 67ee469..30cdffb 100644 --- a/Game/GigLine/Content/Hollywood/Textures/T_Stucco_BC.uasset +++ b/Game/GigLine/Content/Hollywood/Textures/T_Stucco_BC.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:a87d86db92679e2cfb0ed225c6ac3d6e34f205fb8648cba2093e37303b6726d1 +oid sha256:e3dfc26e2f8182165df600a26c077b1e87b8fdb44543d0d495d1e15a77218328 size 62746 diff --git a/Game/GigLine/Content/Hollywood/Textures/T_Stucco_R.uasset b/Game/GigLine/Content/Hollywood/Textures/T_Stucco_R.uasset index 81f99c7..3423c74 100644 --- a/Game/GigLine/Content/Hollywood/Textures/T_Stucco_R.uasset +++ b/Game/GigLine/Content/Hollywood/Textures/T_Stucco_R.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:5a4c0594a0521a2db7c74d6551591003d376cf77477faec0655e701f70d43326 +oid sha256:4cb34f910545251db23de8c3921401261d60ca31194e721cad556eddfde33acc size 17541 diff --git a/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_BladeSign.uasset b/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_BladeSign.uasset index 8352cbc..c27d0fc 100644 --- a/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_BladeSign.uasset +++ b/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_BladeSign.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:e00768b774e632529666e83a8b8943356dc40ae8c1a3d9fd895c839a93051610 +oid sha256:a7b337429c7b695f8bd49084e4e761b0e192dfd1d610128c1ced37750962a507 size 72330 diff --git a/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_BladeSignBracket.uasset b/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_BladeSignBracket.uasset index f29ff76..cdc5958 100644 --- a/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_BladeSignBracket.uasset +++ b/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_BladeSignBracket.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:7de244b231b5f4d577e745991133a84bdff210fa63e93054e8d623c94676012d +oid sha256:1d1d469442d8e804ad9082e018ef64ae99dc5bb6be536978ff1f920870653929 size 72466 diff --git a/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_BladeSignFrame.uasset b/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_BladeSignFrame.uasset index 8d5e092..3ffcfdf 100644 --- a/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_BladeSignFrame.uasset +++ b/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_BladeSignFrame.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:31d0ccd47c81f789de61691862acae016c25003b51f6ae42d2f3a6044c863ba0 +oid sha256:21e808e3084173eca07c262c27a6cf98b08d3fcbfa7afe0d3f8d214bebd25e6f size 72406 diff --git a/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_MarqueeCanopy.uasset b/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_MarqueeCanopy.uasset index 74a33f1..cf75c4e 100644 --- a/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_MarqueeCanopy.uasset +++ b/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_MarqueeCanopy.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:dd5af933606a28116d054ff2f1e5518f0b72a911a61a149fd2b99bf529453bfc +oid sha256:0ebde7b89afeebbf8e1eedd1862d6fc77d18245435c2fd7d75e37b823fa18e22 size 72370 diff --git a/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_MarqueeFascia.uasset b/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_MarqueeFascia.uasset index 91551ea..424edc2 100644 --- a/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_MarqueeFascia.uasset +++ b/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_MarqueeFascia.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:998ec858a89277b37712a78704c8941d914391613999f738da52fd1007aff452 +oid sha256:55ce34ad2533901f50a968425c9d09b1d2f53c35912c430b1b69148dd1c74a09 size 72438 diff --git a/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_MarqueeSoffit.uasset b/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_MarqueeSoffit.uasset index 135ee9b..3a6be16 100644 --- a/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_MarqueeSoffit.uasset +++ b/Game/GigLine/Content/Hollywood/Theatre/SM_Trim_MarqueeSoffit.uasset @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:62fd60425ca0a3f34f313dfafa6fe8e73b7845fd7541d454f0609203297f0693 +oid sha256:2706ac3b10b36ff9cbeaf5a75dc6ee43bace5a3b135a32fda79a95e4c9c6d7ab size 72413 diff --git a/Game/GigLine/Content/Test/ReviewMap.umap b/Game/GigLine/Content/Test/ReviewMap.umap index dcb2947..c5030fb 100644 --- a/Game/GigLine/Content/Test/ReviewMap.umap +++ b/Game/GigLine/Content/Test/ReviewMap.umap @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:2d6a1752d74fb818af96554b2e6b6a9cca2553b916d6e737d68637571de5c2ec +oid sha256:48c5e761b7ff6e935db7233ef182b56e3267055c1944925fd4410b6265480910 size 29389 diff --git a/Game/GigLine/Source/GigLine/GigLineCharacter.cpp b/Game/GigLine/Source/GigLine/GigLineCharacter.cpp index 615f496..e206d94 100644 --- a/Game/GigLine/Source/GigLine/GigLineCharacter.cpp +++ b/Game/GigLine/Source/GigLine/GigLineCharacter.cpp @@ -251,6 +251,19 @@ void AGigLineCharacter::BeginPlay() { StartQASelfTest(); } + + // `-walk` holds forward input from the first frame. The screenshot run uses it + // with `-thirdperson` so a capture can show the walk clip mid-stride: an idle + // shot cannot prove the animation set, and a still cannot show a stride. + bWalkForever = FParse::Param(FCommandLine::Get(), TEXT("walk")); +} + +void AGigLineCharacter::WalkForever() +{ + if (bWalkForever && GetCharacterMovement() && GetCharacterMovement()->IsMovingOnGround()) + { + AddMovementInput(GetActorForwardVector(), 1.0f); + } } void AGigLineCharacter::StartQASelfTest() @@ -726,6 +739,7 @@ void AGigLineCharacter::Tick(float DeltaSeconds) Super::Tick(DeltaSeconds); // Speed-driven animation state: correct whether the player walked, was pushed, // or fell, and independent of which input produced the movement. + WalkForever(); UpdateBodyAnimation(); } diff --git a/Game/GigLine/Source/GigLine/GigLineCharacter.h b/Game/GigLine/Source/GigLine/GigLineCharacter.h index 94dc651..6885fef 100644 --- a/Game/GigLine/Source/GigLine/GigLineCharacter.h +++ b/Game/GigLine/Source/GigLine/GigLineCharacter.h @@ -158,6 +158,12 @@ protected: UPROPERTY() TObjectPtr PlayingAnimation; + /** True while `-walk` holds forward input for the screenshot run. */ + bool bWalkForever = false; + + /** Applies the `-walk` forward input when the flag is set and the pawn is grounded. */ + void WalkForever(); + /** Toggle-camera action (V). */ UPROPERTY(EditDefaultsOnly, BlueprintReadOnly, Category = "Input") TObjectPtr ToggleCameraAction; diff --git a/Screenshots/demo/review-demo-crossing.png b/Screenshots/demo/review-demo-crossing.png index 0872185..574c3ed 100644 --- a/Screenshots/demo/review-demo-crossing.png +++ b/Screenshots/demo/review-demo-crossing.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:60f659b5a0f1808559ef599247d80cb3f9253e633caade6d484670e5f536848a -size 3089752 +oid sha256:592a419db534b1b727654e4d02c18113427511442b147a912a2e2a54a30181cd +size 3088926 diff --git a/Screenshots/demo/review-demo-north-buildings.png b/Screenshots/demo/review-demo-north-buildings.png index 576bc70..ebc5c61 100644 --- a/Screenshots/demo/review-demo-north-buildings.png +++ b/Screenshots/demo/review-demo-north-buildings.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:1e683025a971f703f70e3543aad9ce63998f1f5e04fad5d4d7632ba2caf58e5b -size 2619357 +oid sha256:dacc07a63e622caeb2b6c470a83b83d753ff6cd0aaf5ccbf4759a754b159623e +size 2619131 diff --git a/Screenshots/demo/review-demo-retail-frontage.png b/Screenshots/demo/review-demo-retail-frontage.png index 6655820..8d18a53 100644 --- a/Screenshots/demo/review-demo-retail-frontage.png +++ b/Screenshots/demo/review-demo-retail-frontage.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:289312f2155581043531ad0f1aa0523307ad1dc33c91bc67caebfc69c4ec1b46 -size 2521230 +oid sha256:ed4798f70d275aa59ba6bf29ef7369857137dce7e39858c84ed4aab19c5fb06b +size 2522358 diff --git a/Screenshots/demo/review-demo-spawn-view.png b/Screenshots/demo/review-demo-spawn-view.png index 6ad5765..0a700f8 100644 --- a/Screenshots/demo/review-demo-spawn-view.png +++ b/Screenshots/demo/review-demo-spawn-view.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:2098ab927ce6878d575e5fb1bdc695f0bce53bea13b4a65842e0c793574f2886 -size 2924808 +oid sha256:044c1296381d125242d1c2a17bb03771fb774252d1e0aa6869d36740a0ae2360 +size 2919982 diff --git a/Screenshots/demo/review-demo-street-level.png b/Screenshots/demo/review-demo-street-level.png index 1b12c27..b2b2333 100644 --- a/Screenshots/demo/review-demo-street-level.png +++ b/Screenshots/demo/review-demo-street-level.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:2faa35c83cc30ee89401cd27a14163004f7554ae42f09fea544585bd51c0d26d -size 2850355 +oid sha256:0c2faa7a89b083fcb244d82d72a49a1fac7c8b8a967ce992d3ce7b0a5ebe9a71 +size 2850629 diff --git a/Screenshots/demo/review-demo-third-person-front.png b/Screenshots/demo/review-demo-third-person-front.png index 443aac3..5bdbe3e 100644 --- a/Screenshots/demo/review-demo-third-person-front.png +++ b/Screenshots/demo/review-demo-third-person-front.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:6ca62cbce83fdbc03115fe323a53c00bedff6deaa06467949b1671c4b0d33059 -size 2795559 +oid sha256:ba3bee7d90e5bfc1abe8c247fe7b273e2059eb557b93fb44d32ee97e70f21682 +size 2794850 diff --git a/Screenshots/demo/review-demo-third-person-walk.png b/Screenshots/demo/review-demo-third-person-walk.png new file mode 100644 index 0000000..2e41d9d --- /dev/null +++ b/Screenshots/demo/review-demo-third-person-walk.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:c3a9d55d561a861ffbf4bc5623604453dce50a000ed7dbb46730d429ec8c1273 +size 3164641 diff --git a/Screenshots/demo/review-demo-third-person.png b/Screenshots/demo/review-demo-third-person.png index 6202432..929a1aa 100644 --- a/Screenshots/demo/review-demo-third-person.png +++ b/Screenshots/demo/review-demo-third-person.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:2735ea1f5656ad3d27e5cb076f714108169057e06190b2cd8d3e0593bbe6d8df -size 2996327 +oid sha256:dba912fee130cee2651c4a1f5b6cd1dc2ddadd206450fa9bbafcae5b0730f37d +size 2998064 diff --git a/TODO.md b/TODO.md index b9cd834..81d082f 100644 --- a/TODO.md +++ b/TODO.md @@ -32,7 +32,7 @@ Actionable task list for this project. This file is the single, central place fo ### Release checks -- [ ] Third-person traversal works end-to-end in the demo area. +- [ ] Third-person traversal works end-to-end in the demo area. **Blocked on a capture harness, not on the game:** walking works (`-walk` holds forward input; the pawn crosses the sidewalk while the third-person rig follows), but a fixed review camera cannot catch a pawn moving at 4.5 m/s — three attempts framed it at a different distance each run and the last two missed it entirely. The stride shot was removed rather than shipped broken. Needs a camera that tracks the pawn (attach the shot camera to the pawn, or drive the capture from a recorded path), then re-add `demo-third-person-walk`. - [ ] No blocking animation or rig defects. - [ ] Performance target still met at 1440p. - [ ] Tag `v0.2.0` and write `CHANGELOG.md` entry; then remove this section. diff --git a/Tools/ue_build_review_map.py b/Tools/ue_build_review_map.py index be71576..732b2c5 100644 --- a/Tools/ue_build_review_map.py +++ b/Tools/ue_build_review_map.py @@ -323,6 +323,7 @@ try: # back, so a pose defect there is invisible. The pawn spawns facing +Y # (yaw 90), so the camera stands on the road side and looks back north. ("demo-third-person-front", unreal.Vector(-13336, -520, 700), unreal.Vector(-13336, -1150, 540), 55.0), + ] seq = spawn(unreal.GigLineShotActor, unreal.Vector(0, 0, 300), "ShotSequencer") if seq: