From 91fd123ab41783e00d68a51d990c9fd9af67d289 Mon Sep 17 00:00:00 2001 From: Zwitschi Date: Sat, 7 Nov 2026 15:01:09 +0100 Subject: [PATCH] repo: allow screenshots in the repository - Drop the /Screenshots/* gitignore exclusion so review PNGs are committed (LFS-tracked) alongside the review README. - AGENTS.md Visual review: PNGs are now committed, not kept only on disk. - 13 review/demo screenshots tracked (25 MB LFS). --- .gitignore | 6 ++---- AGENTS.md | 2 +- Screenshots/demo/review-00-demo-spawn-view.png | 3 +++ Screenshots/demo/review-01-demo-street-level.png | 3 +++ Screenshots/demo/review-02-demo-crossing.png | 3 +++ Screenshots/demo/review-03-demo-north-buildings.png | 3 +++ Screenshots/review-00-overview.png | 3 +++ Screenshots/review-01-character.png | 3 +++ Screenshots/review-02-scale-cubes.png | 3 +++ Screenshots/review-03-player-placement.png | 3 +++ Screenshots/review-04-ground-contact.png | 3 +++ Screenshots/review-05-shadow-compare.png | 3 +++ Screenshots/review-06-hero-portals.png | 3 +++ Screenshots/review-07-hero-facade-front.png | 3 +++ Screenshots/review-08-hero-facade-oblique.png | 3 +++ 15 files changed, 42 insertions(+), 5 deletions(-) create mode 100644 Screenshots/demo/review-00-demo-spawn-view.png create mode 100644 Screenshots/demo/review-01-demo-street-level.png create mode 100644 Screenshots/demo/review-02-demo-crossing.png create mode 100644 Screenshots/demo/review-03-demo-north-buildings.png create mode 100644 Screenshots/review-00-overview.png create mode 100644 Screenshots/review-01-character.png create mode 100644 Screenshots/review-02-scale-cubes.png create mode 100644 Screenshots/review-03-player-placement.png create mode 100644 Screenshots/review-04-ground-contact.png create mode 100644 Screenshots/review-05-shadow-compare.png create mode 100644 Screenshots/review-06-hero-portals.png create mode 100644 Screenshots/review-07-hero-facade-front.png create mode 100644 Screenshots/review-08-hero-facade-oblique.png diff --git a/.gitignore b/.gitignore index dfa89fa..f0924f9 100644 --- a/.gitignore +++ b/.gitignore @@ -52,10 +52,8 @@ Thumbs.db # Blender/Blosm working caches /Art/blender/.cache/ -# Rendered screenshots for visual review — generated locally, never committed. -# Keeps only the review README (see AGENTS.md Visual review). -/Screenshots/* -!/Screenshots/README.md +# Rendered screenshots for visual review — committed with the repo (see +# AGENTS.md Visual review) so reviewers see what the build rendered. # Scratch files .tmp-* diff --git a/AGENTS.md b/AGENTS.md index be91a2f..64b3c75 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -100,7 +100,7 @@ Any change that affects the game's appearance — meshes, materials, lighting, l 1. Run `Tools/render_screenshots.sh` (rebuilds `Game/GigLine/Content/Test/ReviewMap.umap` from current content, runs the game on it, captures the fixed camera list, copies the PNGs into `Screenshots/`). 2. Update `Screenshots/README.md`: one row per screenshot with what it shows and an approval state; describe any new shots or scene changes in the same change. -3. The PNGs are **never committed** — `.gitignore` keeps only `Screenshots/README.md`. Review happens on disk. +3. The PNGs **are committed** so reviewers see exactly what the build rendered (`.gitignore` does not exclude them). Keep them in sync with this README: drop retired shots in the same change. 4. Wait for the user's approval before treating a visual change as done; record approval by ticking the table in `Screenshots/README.md`. New content that needs a different camera angle gets a new entry in the shot list in `Tools/ue_build_review_map.py`. diff --git a/Screenshots/demo/review-00-demo-spawn-view.png b/Screenshots/demo/review-00-demo-spawn-view.png new file mode 100644 index 0000000..dc0f647 --- /dev/null +++ b/Screenshots/demo/review-00-demo-spawn-view.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:0f3d6f0c1885b708645092ad7aeae9b94b7bb1f9df69976886d3055a84877fe9 +size 2599672 diff --git a/Screenshots/demo/review-01-demo-street-level.png b/Screenshots/demo/review-01-demo-street-level.png new file mode 100644 index 0000000..71736df --- /dev/null +++ b/Screenshots/demo/review-01-demo-street-level.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:75e2814c90d94fad5789aae830d59238544d5360223be9e40ab59cebdc2f09db +size 1926763 diff --git a/Screenshots/demo/review-02-demo-crossing.png b/Screenshots/demo/review-02-demo-crossing.png new file mode 100644 index 0000000..da100be --- /dev/null +++ b/Screenshots/demo/review-02-demo-crossing.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:8d304878047072351acddaa27bdd571da4948fb0a5dffa4d901ba6f9e88f2b54 +size 1285673 diff --git a/Screenshots/demo/review-03-demo-north-buildings.png b/Screenshots/demo/review-03-demo-north-buildings.png new file mode 100644 index 0000000..7f978cd --- /dev/null +++ b/Screenshots/demo/review-03-demo-north-buildings.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:e604f6d549f854f4fea2d935ad551111ec0b4f3cfad0219549427814196b0ca6 +size 1777325 diff --git a/Screenshots/review-00-overview.png b/Screenshots/review-00-overview.png new file mode 100644 index 0000000..b7f641c --- /dev/null +++ b/Screenshots/review-00-overview.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:d1505cbc55946c31921d720aa37d9611306f8f224f312bcaa44c9be20fb51f8f +size 2431032 diff --git a/Screenshots/review-01-character.png b/Screenshots/review-01-character.png new file mode 100644 index 0000000..c6cf80d --- /dev/null +++ b/Screenshots/review-01-character.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:b561fc09da1d609f36627d7253ee57392709365d87e991e0478e94aa25351729 +size 2474855 diff --git a/Screenshots/review-02-scale-cubes.png b/Screenshots/review-02-scale-cubes.png new file mode 100644 index 0000000..69ced52 --- /dev/null +++ b/Screenshots/review-02-scale-cubes.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:23a344b379225dbb047dd06199a679b7bc28694ceba34b1985253954fd488c07 +size 1909809 diff --git a/Screenshots/review-03-player-placement.png b/Screenshots/review-03-player-placement.png new file mode 100644 index 0000000..5a0eb52 --- /dev/null +++ b/Screenshots/review-03-player-placement.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:9d94797297707283f7c541cd7191bf33dc1e3def84dd5562204041c971ffb090 +size 1964632 diff --git a/Screenshots/review-04-ground-contact.png b/Screenshots/review-04-ground-contact.png new file mode 100644 index 0000000..89886d5 --- /dev/null +++ b/Screenshots/review-04-ground-contact.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:c7d8ef949f148f1f076c36377ffd606f83dacec44423ce901337b8ac83f9516f +size 1839543 diff --git a/Screenshots/review-05-shadow-compare.png b/Screenshots/review-05-shadow-compare.png new file mode 100644 index 0000000..d348422 --- /dev/null +++ b/Screenshots/review-05-shadow-compare.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:306ec54dab6ed6498fc401024a57ada32903baaa357b62d033911db8c3fdd64a +size 1672855 diff --git a/Screenshots/review-06-hero-portals.png b/Screenshots/review-06-hero-portals.png new file mode 100644 index 0000000..0794217 --- /dev/null +++ b/Screenshots/review-06-hero-portals.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:6ab647c7cce9db83a79875b8eaa42205f4468ff957a59c67e90fb4b4e133ddd3 +size 1752976 diff --git a/Screenshots/review-07-hero-facade-front.png b/Screenshots/review-07-hero-facade-front.png new file mode 100644 index 0000000..45cb56f --- /dev/null +++ b/Screenshots/review-07-hero-facade-front.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:ccf12d909e095f113f655df87efa3bf27f5fe05a547e5647590ecb3bcbbc27a7 +size 2048644 diff --git a/Screenshots/review-08-hero-facade-oblique.png b/Screenshots/review-08-hero-facade-oblique.png new file mode 100644 index 0000000..5f87c2c --- /dev/null +++ b/Screenshots/review-08-hero-facade-oblique.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:6cf0d70b3a5e8ea97e1f77b56b38e4f73a47b909c2bdf4bf64cd981d998ed3bf +size 1924852