Refactor code for improved readability and consistency
CI / lint-test-build (push) Failing after 12s

- Consolidated multiline string formatting into single-line for SQL queries in multiple files.
- Adjusted argument formatting in function calls for better alignment and readability.
- Removed unnecessary line breaks and improved spacing in various sections of the codebase.
- Updated test cases to maintain consistency in formatting and improve clarity.
This commit is contained in:
2026-06-04 19:04:30 +02:00
parent 7d18bdf316
commit c8e3daeb57
21 changed files with 377 additions and 383 deletions
+14 -26
View File
@@ -31,9 +31,7 @@ def mock_audit_repo():
return audit_repo
def test_configuration_service_initialization(
mock_settings, mock_store, mock_audit_repo
):
def test_configuration_service_initialization(mock_settings, mock_store, mock_audit_repo):
"""Test that ConfigurationService initializes correctly."""
# Create service instance
service = ConfigurationService(mock_settings, mock_store, mock_audit_repo)
@@ -46,9 +44,7 @@ def test_configuration_service_initialization(
assert isinstance(service._loaded_settings, dict)
def test_configuration_service_get_setting(
mock_settings, mock_store, mock_audit_repo
):
def test_configuration_service_get_setting(mock_settings, mock_store, mock_audit_repo):
"""Test getting configuration settings."""
# Create service instance
service = ConfigurationService(mock_settings, mock_store, mock_audit_repo)
@@ -65,15 +61,13 @@ def test_configuration_service_get_setting(
assert result == "default"
def test_configuration_service_set_setting(
mock_settings, mock_store, mock_audit_repo
):
def test_configuration_service_set_setting(mock_settings, mock_store, mock_audit_repo):
"""Test setting configuration settings."""
# Create service instance
service = ConfigurationService(mock_settings, mock_store, mock_audit_repo)
# Mock the repository
with patch('arbitrade.config.service.ConfigSettingRepository') as mock_repo_class:
with patch("arbitrade.config.service.ConfigSettingRepository") as mock_repo_class:
mock_repo_instance = Mock()
mock_repo_class.return_value = mock_repo_instance
@@ -90,9 +84,7 @@ def test_configuration_service_set_setting(
mock_repo_instance.create_setting.assert_called_once()
def test_configuration_service_hot_reload_detection(
mock_settings, mock_store, mock_audit_repo
):
def test_configuration_service_hot_reload_detection(mock_settings, mock_store, mock_audit_repo):
"""Test hot-reload detection functionality."""
# Create service instance
service = ConfigurationService(mock_settings, mock_store, mock_audit_repo)
@@ -101,27 +93,26 @@ def test_configuration_service_hot_reload_detection(
assert service.is_config_outdated() is False
# Test with mock repository that returns a timestamp
with patch('arbitrade.config.service.ConfigSettingRepository') as mock_repo_class:
with patch("arbitrade.config.service.ConfigSettingRepository") as mock_repo_class:
mock_repo_instance = Mock()
mock_repo_class.return_value = mock_repo_instance
# Mock the latest updated at timestamp
from datetime import datetime
mock_repo_instance.get_latest_updated_at.return_value = datetime.now()
# Should detect as outdated when timestamp exists
assert service.is_config_outdated() is True
def test_configuration_service_reload_if_changed(
mock_settings, mock_store, mock_audit_repo
):
def test_configuration_service_reload_if_changed(mock_settings, mock_store, mock_audit_repo):
"""Test hot-reload functionality."""
# Create service instance
service = ConfigurationService(mock_settings, mock_store, mock_audit_repo)
# Mock the repository
with patch('arbitrade.config.service.ConfigSettingRepository') as mock_repo_class:
with patch("arbitrade.config.service.ConfigSettingRepository") as mock_repo_class:
mock_repo_instance = Mock()
mock_repo_class.return_value = mock_repo_instance
@@ -135,6 +126,7 @@ def test_configuration_service_reload_if_changed(
# Mock the latest updated at timestamp to return a value
from datetime import datetime
mock_repo_instance.get_latest_updated_at.return_value = datetime.now()
# Should reload when outdated
@@ -143,9 +135,7 @@ def test_configuration_service_reload_if_changed(
assert service.get_config_version() == 1
def test_configuration_service_get_config_version(
mock_settings, mock_store, mock_audit_repo
):
def test_configuration_service_get_config_version(mock_settings, mock_store, mock_audit_repo):
"""Test getting configuration version."""
# Create service instance
service = ConfigurationService(mock_settings, mock_store, mock_audit_repo)
@@ -154,7 +144,7 @@ def test_configuration_service_get_config_version(
assert service.get_config_version() == 0
# After setting a value, version should increment
with patch('arbitrade.config.service.ConfigSettingRepository') as mock_repo_class:
with patch("arbitrade.config.service.ConfigSettingRepository") as mock_repo_class:
mock_repo_instance = Mock()
mock_repo_class.return_value = mock_repo_instance
@@ -166,9 +156,7 @@ def test_configuration_service_get_config_version(
assert service.get_config_version() == 1
def test_configuration_service_get_last_updated_at(
mock_settings, mock_store, mock_audit_repo
):
def test_configuration_service_get_last_updated_at(mock_settings, mock_store, mock_audit_repo):
"""Test getting last updated timestamp."""
# Create service instance
service = ConfigurationService(mock_settings, mock_store, mock_audit_repo)
@@ -177,7 +165,7 @@ def test_configuration_service_get_last_updated_at(
assert service.get_last_updated_at() is None
# After setting a value, should have timestamp
with patch('arbitrade.config.service.ConfigSettingRepository') as mock_repo_class:
with patch("arbitrade.config.service.ConfigSettingRepository") as mock_repo_class:
mock_repo_instance = Mock()
mock_repo_class.return_value = mock_repo_instance